Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include parameters items field #36

Merged
merged 1 commit into from
Jan 20, 2017
Merged

Include parameters items field #36

merged 1 commit into from
Jan 20, 2017

Conversation

gabisurita
Copy link
Collaborator

include missing items field when using arrays on query/header parameters.

@coveralls
Copy link

coveralls commented Jan 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 3d79592 on parameter-items into 8c22a3e on master.

@gabisurita gabisurita merged commit 1a333b2 into master Jan 20, 2017
@gabisurita gabisurita deleted the parameter-items branch January 20, 2017 03:27
glasserc
glasserc reviewed Jan 20, 2017
View reviewed changes
cornice_swagger/converters/parameters.py

if schema.get('type') == 'array':
converted['items'] = {}
converted['items']['type'] = schema['items']['type']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but it could have been converted['items'] = {'type': schema['items']['type']}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glasserc glasserc glasserc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabisurita @coveralls @glasserc