Convert pathlib objects to str when used as argument to librosa.load() #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is also another instance of librosa.load in the collab that could be fixed. Are we maintaining that one too? Also, I verified that librosa.output.write_wav does not have this issue. |
ghost
requested a review
from 
ghost
self-assigned this
|
CorentinJ
approved these changes
Jun 23, 2020
ghost
mentioned this pull request
This was referenced Jul 5, 2020
trojblue
added a commit
to trojblue/zhrtvc
that referenced
this pull request
Jul 30, 2020
修改的部分和这个一样, CorentinJ/Real-Time-Voice-Cloning#371, 在eav_fpath前面加上str防止出错
trojblue
added a commit
to trojblue/zhrtvc
that referenced
this pull request
Jul 30, 2020
修改的部分和这个一样, CorentinJ/Real-Time-Voice-Cloning#371, 在wav_fpath前面加上str防止在打开文件的时候出现"File contains data in an unknown format"
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of librosa>=0.7.0 do not accept a pathlib object for librosa.load()
This will break demo_cli.py among other things. There was a fix for this in #331 but was not implemented because since it went too far in removing existing usage of pathlib.