Add test to case when error context size goes outside content size #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
+ Coverage 68.48% 68.68% +0.19%
==========================================
Files 30 30
Lines 1431 1440 +9
==========================================
+ Hits 980 989 +9
Misses 451 451
Continue to review full report at Codecov.
|
MaxDesiatov
requested changes
Jan 7, 2019
There was a problem hiding this comment.
Thanks @hodovani, LGTM except that empty ErrorContextTests.swift file should be removed before merging
| // Created by Matvii Hodovaniuk on 1/7/19. | ||
| // | ||
|
|
||
| import Foundation |
There was a problem hiding this comment.
was this mostly empty file committed by mistake?
There was a problem hiding this comment.
@MaxDesiatov yes, I can't see this file through Xcode. It was committed by mistake.
|
LGTM, too. 🙂 |
MaxDesiatov
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13