Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(component): code improvements #42

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Conversation

ZhenhangTung
Copy link

This PR does:

  • remove else statement
  • set PLATFORM_ID to a read-only field

* fix(component): fix the issue of SSR

* fix(component): use AfterViewInit

* chore(component): use the original ver

* chore(component): prettify code

* chore(component): platformId is readonly
@Cordobo Cordobo self-assigned this Apr 19, 2019
@Cordobo Cordobo merged commit 8e01e45 into Cordobo:development Apr 19, 2019
Cordobo added a commit that referenced this pull request Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants