Skip to content

Conversation

feniup
Copy link
Collaborator

@feniup feniup commented Nov 20, 2024

Had to remove timing_wrap, because the VectorMatrix module had to die.


let remove_zero_rows m =
let entries' = List.filter (fun row -> row <> []) m.entries in
if List.length entries' = 0 then empty() else

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: semgrep.list-length-compare-0 Warning

computing list length is inefficient for emptiness checking, compare with [] instead
@feniup feniup merged commit b1beb54 into master Nov 21, 2024
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant