Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added react-native setup + plugging store within it #1034

Closed
wants to merge 5 commits into from
Closed

added react-native setup + plugging store within it #1034

wants to merge 5 commits into from

Conversation

chrisdugne
Copy link
Contributor

@chrisdugne chrisdugne commented Oct 20, 2017 •
edited
Loading

added devDependencies

 "babel-preset-react-native": "4.0.0"

added dependencies

    "react-native": "^0.49.3",

added:

.
├── android
├── ios

src/mobile
├── App.js
└── index.js

chrisdugne
chrisdugne commented Oct 20, 2017
View reviewed changes
...ages/@coorpacademy-app-player/android/app/src/main/java/com/slideplayer/MainApplication.java

@Override
protected String getJSMainModuleName() {
return "src/mobile/index";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pour info ===> modification custom ici

chrisdugne
chrisdugne commented Oct 25, 2017
View reviewed changes
packages/@coorpacademy-app-player/ios/SlidePlayer/AppDelegate.m
{
NSURL *jsCodeLocation;

jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"src/mobile/index" fallbackResource:nil];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pour info ===> modification custom ici pour ios

@chrisdugne chrisdugne requested a review from godu October 25, 2017 14:53
@codecov
Copy link

codecov bot commented Oct 25, 2017 •
edited
Loading

Codecov Report

Merging #1034 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1034   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files         268      268           
  Lines        3960     3960           
=======================================
  Hits         3784     3784           
  Misses        176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbdbd8e...a81eac8. Read the comment docs.

godu
godu suggested changes Oct 30, 2017
View reviewed changes
Copy link
Contributor

@godu godu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faudrait qu'on soit passé à react@16 avant de merger ça. Il y a surement des choses à faire sur react-linked-input avant.

@chrisdugne
Copy link
Contributor Author

chrisdugne commented Nov 15, 2017 •
edited
Loading

react 16 en cours ici #1082 ✅

@chrisdugne
Copy link
Contributor Author

---> cest pret ici @godu

@chrisdugne
Copy link
Contributor Author

https://github.com/CoorpAcademy/mobile/pull/34

@chrisdugne chrisdugne closed this Jan 21, 2019
@chrisdugne chrisdugne deleted the react-native branch January 21, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godu godu godu requested changes

Assignees
No one assigned
Labels
R&D RFR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisdugne @godu