fixed few components

CoorpAcademy · Nov 15, 2017 · 8ad505e · 8ad505e
1 parent f35ce74
commit 8ad505e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/packages/@coorpacademy-components/src/molecule/brand-create-form/index.js b/packages/@coorpacademy-components/src/molecule/brand-create-form/index.js
@@ -24,7 +24,7 @@ const BrandCreateForm = props => {
             <input
               type="text"
               placeholder={field.placeholder}
-              value={field.value}
+              defaultValue={field.value}
               onInput={handleChange}
             />
             {field.label}

diff --git a/packages/@coorpacademy-components/src/molecule/card/index.js b/packages/@coorpacademy-components/src/molecule/card/index.js
@@ -2,6 +2,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import classnames from 'classnames';
 import get from 'lodash/fp/get';
+import noop from 'lodash/fp/noop';
 import keys from 'lodash/fp/keys';
 import isEmpty from 'lodash/fp/isEmpty';
 import pick from 'lodash/fp/pick';
@@ -96,15 +97,19 @@ const Card = (props, context) => {
               backgroundImage: image ? `url('${image}')` : 'none'
             }}
           >
-            <div data-name="cover" className={style.ctaWrapper} onClick={!disabled && onClick}>
+            <div
+              data-name="cover"
+              className={style.ctaWrapper}
+              onClick={!disabled ? onClick : noop}
+            >
               {freeRunIcon}
               {emptyIcon}
               {adaptivIcon}
               {timer}
             </div>
           </div>
           {myprogress}
-          <div data-name="info" className={style.infoWrapper} onClick={!disabled && onClick}>
+          <div data-name="info" className={style.infoWrapper} onClick={!disabled ? onClick : noop}>
             <div
               data-name="type"
               className={classnames(style.type, empty ? style.empty : null)}

diff --git a/packages/@coorpacademy-components/src/molecule/questions/free-text/index.js b/packages/@coorpacademy-components/src/molecule/questions/free-text/index.js
@@ -6,18 +6,17 @@ import Provider from '../../../atom/provider';
 import style from './style.css';
 
 const FreeText = (props, {skin}) => {
-  const {placeholder = '', value, defaultValue, onChange = noop} = props;
+  const {placeholder = '', value = '', onChange = noop} = props;
 
   const handleChange = e => onChange(e.target.value);
-  const skinView = value || defaultValue ? get('common.primary', skin) : null;
+  const skinView = value ? get('common.primary', skin) : null;
 
   return (
     <div data-name="freeText" className={style.wrapper}>
       <input
         type="text"
         className={style.input}
         placeholder={placeholder}
-        defaultValue={defaultValue}
         value={value}
         onInput={handleChange}
         onChange={noop}