-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lossless trimming to avoid frozen frames at start of videos #9
base: master
Are you sure you want to change the base?
Conversation
--- If the start or end of an episode happens to land right on a keyframe, don't re-render that part of the episode or attempt to use that cap in the concatenation process.
Usually if a smarttrim file is missing it's just because it was never created in the first place.
For some reason github didn't send an alert that this pull request was even made! My apologies! I personally adore Lossless Cut and use it somewhat often for making clips. One quirk with smart cut is the replayability problems that seem to plague the still-ongoing issue - mifi/lossless-cut#126 (Which is recently celebrating being open for 6 years! 🎉) Have you noticed any weird timing or compatibility issues during your testing? I'll set up a development instance with your fork and see how it works for a few days, just to be sure the resulting files play well with VLC/MPC/Plex/Jellyfin. |
I haven't tried playing the files with everything you listed but I've tried with VLC, Media Player Classic and Plex via web browser (all on Windows) and all seem to work fine for me. My guess regarding the replayability issues is that Lossless Cut might be having trouble with some specific (potentially exotic) combinations of codec, bitrate, etc. whereas we only have to worry about a few specific combinations, since we know what our video source is going to be. Hopefully it works as well for you as it does for me! |
This PR attempts to fix a few minor problems with nhk-record:
To sum up the changes:
I've been running this version of nhk-record for several months now, fixing things along the way, and I think it's ready for wider use. That said, there's a lot going on here so no hard feelings if you'd rather decline this or don't have the time to review!