Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NODE-1972] NODE_MODULE to NODE_MODULE_INIT #33

Merged
merged 1 commit into from
Jan 14, 2022
Merged

[NODE-1972] NODE_MODULE to NODE_MODULE_INIT #33

merged 1 commit into from
Jan 14, 2022

Conversation

Yavorss
Copy link
Contributor

@Yavorss Yavorss commented Jan 11, 2022 •
edited
Loading

When we use the agent with a sever that uses worker threads there is an error

error: 2021-11-05T17:03:54.792Z 17509 contrast:contrast-init - Unexpected error while trying to start contrast. Continuing without instrumentation.
Error: failed to load funcinfo.node

I found this as a solution nodejs/node#21783 (comment)

@jcolekaplan jcolekaplan self-assigned this Jan 11, 2022
@Yavorss Yavorss changed the title NODE_MODULE to NODE_MODULE_INIT [NODE-1972] NODE_MODULE to NODE_MODULE_INIT Jan 11, 2022
jcolekaplan
jcolekaplan approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@jcolekaplan jcolekaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that most of this is formatting. The functional stuff looks good and I confirmed it's working.

@Yavorss Yavorss merged commit 8b1195e into main Jan 14, 2022
@tough-griff tough-griff deleted the NODE-1972 branch June 9, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcolekaplan jcolekaplan jcolekaplan approved these changes

@tough-griff tough-griff Awaiting requested review from tough-griff

Assignees

@jcolekaplan jcolekaplan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yavorss @jcolekaplan