fix(authz): fail closed on non-string OIDC subject claims - #66
Merged
cursor[bot] merged 1 commit intoAug 17, 2026
Merged
Conversation
Strix flagged the preferred_username/email/sub or-chain as subject injection because a signed non-string claim was coerced into ActorContext.subject. Require a non-empty string alias, keep JSON-null fall-through, and map every JWT crit failure to one application error without classifying PyJWT exception text. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
cursor
Bot
merged commit Aug 17, 2026
80966ae
into
codex/keyverse-oidc-claim-aliases
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strix Security Scan failed on PR #58 head
9348983803fd6dda5d77e0ded80ab9ee3d72bf06with MEDIUM findingvuln-0001: thepreferred_username or email or sub or "anonymous"chain accepted signed non-string subject claims and coerced them intoActorContext.subject.This change is fast-forwarded onto
codex/keyverse-oidc-claim-aliases(PR #58 head80966aede42682b993f3f269a543e96f07e92514) so the required Strix check can re-run on #58.preferred_username/email/sub; JSON-null may fall throughcritfailure to one application error without classifying PyJWT exception textsrc/sdp/authz.pyis 100% coveredVerification
PYTHONPATH=src python3 -m pytest— 294 passed, 8 skippedcoverage report --include=src/sdp/authz.py— 100%Strix evidence
Insecure Direct Object Reference (IDOR) via JWT subject claim injection