Skip to content

๐ŸŽจ Palette: ์š”์•ฝ ์นด๋“œ ํˆดํŒ ํ‚ค๋ณด๋“œ ์ ‘๊ทผ์„ฑ ๊ฐœ์„  - #617

Closed
seonghobae wants to merge 6 commits into
developfrom
palette-summary-card-a11y-9750894586752617750
Closed

๐ŸŽจ Palette: ์š”์•ฝ ์นด๋“œ ํˆดํŒ ํ‚ค๋ณด๋“œ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ #617
seonghobae wants to merge 6 commits into
developfrom
palette-summary-card-a11y-9750894586752617750

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

๐Ÿ’ก ๋ฌด์—‡์„

  • index.html์˜ .meta-value-card (์ „์ฒด์ผ์ˆ˜, ๊ณ„ํš์ง„์ฒ™๋ฅ , ์‹ค์ ์ง„์ฒ™๋ฅ ) ์š”์†Œ์— tabindex="0"๊ณผ role="note" ์†์„ฑ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • styles.css์— .meta-value-card:focus-visible ์„ ํƒ์ž๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ํ‚ค๋ณด๋“œ ํฌ์ปค์Šค ์‹œ ๋ธŒ๋ผ์šฐ์ € ๊ธฐ๋ณธ ํฌ์ปค์Šค ๋ง์ด ๋ณด์ด๋„๋ก ๊ธฐ์กด ๋ฒ„ํŠผ๋“ค๊ณผ ๋™์ผํ•œ ์Šคํƒ€์ผ์„ ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค.

๐ŸŽฏ ์™œ

  • ํ”„๋กœ์ ํŠธ ์ƒํƒœ๋ฅผ ๋‚˜ํƒ€๋‚ด๋Š” ์š”์•ฝ ์นด๋“œ์—๋Š” ๊ฐ๊ฐ์˜ ์˜๋ฏธ๋ฅผ ์„ค๋ช…ํ•˜๋Š” ์ค‘์š”ํ•œ title ํˆดํŒ ์ •๋ณด๊ฐ€ ํฌํ•จ๋˜์–ด ์žˆ์Šต๋‹ˆ๋‹ค.
  • ํ•˜์ง€๋งŒ <div>์™€ ๊ฐ™์€ ๋น„๋Œ€ํ™”ํ˜• ์š”์†Œ์—๋งŒ ํˆดํŒ์ด ์ •์˜๋˜์–ด ์žˆ์–ด ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ๋ฐ ํ‚ค๋ณด๋“œ(Tab) ๋‚ด๋น„๊ฒŒ์ด์…˜ ์‚ฌ์šฉ์ž๋Š” ์ด ์ถ”๊ฐ€ ์„ค๋ช…์„ ์ธ์ง€ํ•˜๊ฑฐ๋‚˜ ์ ‘๊ทผํ•  ์ˆ˜ ์—†๋Š” ์ ‘๊ทผ์„ฑ ๋ฌธ์ œ๊ฐ€ ์žˆ์—ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ ๋ณ€๊ฒฝ ์ „/ํ›„

  • ๋ณ€๊ฒฝ ์ „: ์š”์•ฝ ์นด๋“œ๊ฐ€ ํ‚ค๋ณด๋“œ ํƒญ(Tab) ํ๋ฆ„์— ํฌํ•จ๋˜์ง€ ์•Š์œผ๋ฉฐ, ์‹œ๊ฐ์ ์œผ๋กœ๋„ ํฌ์ปค์Šค ์ƒํƒœ๋ฅผ ์•Œ ์ˆ˜ ์—†์Œ.
  • ๋ณ€๊ฒฝ ํ›„: ํƒญ ํ‚ค๋ฅผ ๋ˆŒ๋ €์„ ๋•Œ ์š”์•ฝ ์นด๋“œ๊ฐ€ ํฌ์ปค์Šค๋ฅผ ๋ฐ›์„ ์ˆ˜ ์žˆ์œผ๋ฉฐ, ํŒŒ๋ž€์ƒ‰ ํ…Œ๋‘๋ฆฌ(outline)๊ฐ€ ํ‘œ์‹œ๋˜์–ด ํˆดํŒ ์ •๋ณด๋ฅผ ํ‚ค๋ณด๋“œ๋กœ๋„ ํ™•์ธํ•  ์ˆ˜ ์žˆ์Œ.

โ™ฟ ์ ‘๊ทผ์„ฑ

  • tabindex="0": ๋น„๋Œ€ํ™”ํ˜• ์š”์†Œ๋ฅผ ํ‚ค๋ณด๋“œ ๋‚ด๋น„๊ฒŒ์ด์…˜ ์ˆœ์„œ์— ํฌํ•จ์‹œ์ผฐ์Šต๋‹ˆ๋‹ค.
  • role="note": ์Šคํฌ๋ฆฐ ๋ฆฌ๋”๊ฐ€ ๋‹จ์ˆœํ•œ ์ปจํ…Œ์ด๋„ˆ(div)๊ฐ€ ์•„๋‹ˆ๋ผ ๋ถ€๊ฐ€์ ์ธ ์ •๋ณด๋‚˜ ๋ฉ”๋ชจ๋ฅผ ๋‹ด๊ณ  ์žˆ๋Š” ์˜๋ฏธ ์žˆ๋Š” ์š”์†Œ๋กœ ํ•ด์„ํ•˜๋„๋ก ์‹œ๋งจํ‹ฑ ์—ญํ• ์„ ๋ถ€์—ฌํ–ˆ์Šต๋‹ˆ๋‹ค.
  • :focus-visible: ๋งˆ์šฐ์Šค ์‚ฌ์šฉ์ž์˜ ๊ฒฝํ—˜์€ ๊ทธ๋Œ€๋กœ ์œ ์ง€ํ•˜๋ฉด์„œ ํ‚ค๋ณด๋“œ ์‚ฌ์šฉ์ž์—๊ฒŒ๋งŒ ํฌ์ปค์Šค ์ƒํƒœ๋ฅผ ๋ช…ํ™•ํ•˜๊ฒŒ ์‹œ๊ฐ์ ์œผ๋กœ ์ „๋‹ฌํ•ฉ๋‹ˆ๋‹ค.

PR created automatically by Jules for task 9750894586752617750 started by @seonghobae


Devin Review

Summary by CodeRabbit

  • ์ ‘๊ทผ์„ฑ ๊ฐœ์„ 

    • ์š”์•ฝ ์ •๋ณด ์นด๋“œ(์ „์ฒด์ผ์ˆ˜, ๊ณ„ํš ์ง„์ฒ™๋ฅ , ์‹ค์  ์ง„์ฒ™๋ฅ )๋ฅผ ํ‚ค๋ณด๋“œ๋กœ ํƒ์ƒ‰ํ•  ์ˆ˜ ์žˆ๋„๋ก ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
    • ์นด๋“œ์˜ ์˜๋ฏธ๊ฐ€ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์— ๋” ๋ช…ํ™•ํ•˜๊ฒŒ ์ „๋‹ฌ๋˜๋„๋ก ๋ณด์กฐ ๊ธฐ์ˆ ์šฉ ์—ญํ• ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
    • ํ‚ค๋ณด๋“œ๋กœ ํฌ์ปค์Šค๋œ ์นด๋“œ๊ฐ€ ์‹œ๊ฐ์ ์œผ๋กœ ๊ตฌ๋ถ„๋˜๋„๋ก ํฌ์ปค์Šค ํ‘œ์‹œ ์Šคํƒ€์ผ์„ ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค.
    • ๊ธฐ์กด ๋งˆ์šฐ์Šค ์˜ค๋ฒ„ ํˆดํŒ์€ ๊ทธ๋Œ€๋กœ ์œ ์ง€๋ฉ๋‹ˆ๋‹ค.
  • ๋ฌธ์„œ

    • ๋น„๋Œ€ํ™”ํ˜• ์š”์†Œ์˜ ํˆดํŒ ์ ‘๊ทผ์„ฑ ๊ฐœ์„  ๋ฐฉ๋ฒ•์— ๋Œ€ํ•œ ํ•™์Šต ๋…ธํŠธ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๋น„๋Œ€ํ™”ํ˜• ์š”์†Œ์ธ `.meta-value-card`์— ์ œ๊ณต๋˜๋Š” `title` ํˆดํŒ ์ •๋ณด๊ฐ€
ํ‚ค๋ณด๋“œ ์‚ฌ์šฉ์ž ๋ฐ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ํ™˜๊ฒฝ์— ๋…ธ์ถœ๋  ์ˆ˜ ์žˆ๋„๋ก
`tabindex="0"`์™€ `role="note"` ์†์„ฑ์„ ์ถ”๊ฐ€ํ•˜๊ณ ,
ํฌ์ปค์Šค ์ƒํƒœ๋ฅผ ๋ช…ํ™•ํžˆ ์ธ์ง€ํ•  ์ˆ˜ ์žˆ๋„๋ก `:focus-visible` ์Šคํƒ€์ผ์„ ์ ์šฉํ•˜์˜€์Šต๋‹ˆ๋‹ค.
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 45 minutes.

View limit details

Limit details: Youโ€™ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a7227373-c208-4485-afc0-207e0c00cf7d

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between d248138 and 09c8b02.

๐Ÿ“’ Files selected for processing (3)
  • index.html
  • summary-card-accessibility.css
  • tests/e2e/toast-accessibility.spec.js
๐Ÿ“ Walkthrough

Walkthrough

์„ธ ์š”์•ฝ ์นด๋“œ๊ฐ€ ํ‚ค๋ณด๋“œ๋กœ ํฌ์ปค์Šค๋  ์ˆ˜ ์žˆ๊ณ  ๋…ธํŠธ๋กœ ์ „๋‹ฌ๋˜๋„๋ก HTML๊ณผ CSS๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ด€๋ จ ์ ‘๊ทผ์„ฑ ํ•™์Šต ๋…ธํŠธ๋„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

Changes

์š”์•ฝ ์นด๋“œ ์ ‘๊ทผ์„ฑ

Layer / File(s) Summary
์š”์•ฝ ์นด๋“œ ์ ‘๊ทผ์„ฑ ์ ์šฉ
index.html, styles.css, .jules/palette.md
์„ธ ์š”์•ฝ ์นด๋“œ์— tabindex="0"๊ณผ role="note"๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ธฐ์กด title ํˆดํŒ์€ ์œ ์ง€ํ–ˆ์Šต๋‹ˆ๋‹ค. .meta-value-card์— :focus-visible ์•„์›ƒ๋ผ์ธ์„ ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ด€๋ จ ์ ‘๊ทผ์„ฑ ํ•™์Šต ๋…ธํŠธ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ๐Ÿ”ต Low ยท up to d2481

The summary cards now receive keyboard focus, but their explanatory content still relies only on title tooltips, which may not be consistently available to screen-reader or keyboard users. The change is mergeable with explicit follow-up to provide accessible descriptions and verify the focused-card behavior.

Suggested reviewers: cursoragent

๐Ÿšฅ Pre-merge checks | โœ… 5
โœ… Passed checks (5 passed)
Check name Status Explanation
Description Check โœ… Passed Check skipped - CodeRabbitโ€™s high-level summary is enabled.
Title check โœ… Passed ์ œ๋ชฉ์€ ์š”์•ฝ ์นด๋“œ ํˆดํŒ์˜ ํ‚ค๋ณด๋“œ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ ์ด๋ผ๋Š” ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ์ •ํ™•ํ•˜๊ณ  ๊ฐ„๊ฒฐํ•˜๊ฒŒ ์„ค๋ช…ํ•ฉ๋‹ˆ๋‹ค.
Docstring Coverage โœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0โ€ฆ
Linked Issues check โœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check โœ… Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

โœจ Finishing Touches
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-summary-card-a11y-9750894586752617750

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

โœ… Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

coderabbitai[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Devin Review

Comment thread index.html
Comment on lines +33 to 37
<div class="meta-value-card" tabindex="0" role="note" aria-describedby="summary-total-days-description">
<span class="meta-label">์ „์ฒด์ผ์ˆ˜</span>
<strong data-testid="summary-total-days" id="summary-total-days">0์ผ</strong>
<span class="meta-card-description" id="summary-total-days-description">ํ”„๋กœ์ ํŠธ์˜ ์ž‘์—… ๊ธฐ๊ฐ„(์ผ์ˆ˜) ํ•ฉ๊ณ„์ž…๋‹ˆ๋‹ค.</span>
</div>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ” Description may be announced twice by screen readers

Each card carries role="note" and contains the .meta-card-description span as a child while also pointing to it through aria-describedby. On focus a screen reader can announce that text both as note content and as the description. The span is visibility: hidden by default, which limits the effect, but this is worth checking with an actual screen reader.

Devin Review

Was this helpful? React with ๐Ÿ‘ or ๐Ÿ‘Ž to provide feedback.

Copy link
Copy Markdown
Contributor Author

Closing as superseded by #509 after fresh exact-head comparison against protected develop@2c328875e00e86537df3e965170be80532571cad.

#617 current head 09c8b029b90486ce9acc3cb690356d87a97de86b solves the same three summary-card explanation surface by making otherwise static cards synthetic keyboard stops (tabindex="0", role="note") and showing hidden aria-describedby text on focus/hover. The current review state still has an unresolved exact-head Devin concern that the child description can be announced twice because it is both note content and the ARIA description.

#509 current head ea9027743ebafd1ca5774a5a14227585cf796052 already owns this buyer-visible accessibility repair with the stronger non-interactive contract: the same explanations are persistent visible DOM text for pointer, touch, keyboard, and assistive-technology users; static cards remain out of the tab order with no synthetic role/tabindex/title; its browser regressions reject reintroduction of those attributes; and it adds executable normal-text contrast coverage across the accent gradients plus the current W3C/WAI traceability record.

No unique product behavior in #617 needs preservation beyond #509. Keeping both open would create competing accessibility contracts on the same index.html/styles.css surface and risks reintroducing the synthetic-tab-stop design that #509 explicitly tests against.

@seonghobae seonghobae closed this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant