-
Notifications
You must be signed in to change notification settings - Fork 0
fix: preserve numeric zero values through work-item normalization #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seonghobae
wants to merge
32
commits into
develop
Choose a base branch
from
fix/preserve-zero-normalization-609
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
46d3ce8
test: reproduce numeric zero loss through editor round trip
seonghobae 005918c
test: run numeric zero regression in cloud e2e
seonghobae a9e8c86
test: cover zero normalization and CSV export
seonghobae 41a38d6
fix: preserve numeric zero values across normalization
seonghobae bb2a225
test: guard unrelated falsy editor semantics
seonghobae 4646c41
fix: apply CodeRabbit auto-fixes
coderabbitai[bot] 0b741fc
test: keep non-zero falsy numeric inputs empty
seonghobae fb381e8
fix: preserve only numeric zero in normalization
seonghobae dbb30de
test: keep zero preservation numeric-field scoped
seonghobae 7c5617e
test: retain validated zero round-trip contract
seonghobae ea20d5d
test: bound numeric-zero preservation to numeric fields
seonghobae f607152
fix: scope numeric-zero preservation to numeric fields
seonghobae b803db1
fix: keep Hono lockfile aligned
seonghobae 6c8b282
test: cover numeric zero in JSON sync
seonghobae 5c34c79
fix: preserve numeric fields in JSON sync
seonghobae df7ef92
test: cover planning metadata JSON sync
seonghobae 40f2621
fix: preserve planning metadata in JSON sync
seonghobae 4c873b1
test: reject falsy nonnumeric JSON sync metadata
seonghobae 3bb2bd9
fix: normalize nonnumeric sync metadata
seonghobae 0ead5e6
fix(security): align Hono with 4.13.5 advisories
seonghobae bd538f0
fix: restore modulepreload contracts
seonghobae 3566962
test: reproduce JSON sync bootstrap race
seonghobae 9ef18de
fix: gate JSON sync until planner hydration completes
seonghobae 6ec8bef
fix: load JSON sync bootstrap guard fail-closed
seonghobae d97808c
test: require cloud serving for JSON sync guard
seonghobae 45d5eb2
fix: serve JSON sync bootstrap guard
seonghobae 4c965cb
test: run JSON sync static route regression
seonghobae 5a905d4
test: fail when JSON sync guard escapes coverage
seonghobae 2bc9ae2
test: cover JSON sync bootstrap guard behavior
seonghobae 10c91ab
fix(ci): measure JSON sync bootstrap guard coverage
seonghobae f8c3178
test(ci): fail when required workflow skips coverage
seonghobae 5c1f7ec
test(ci): keep workflow coverage repair in owning lane
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
|
seonghobae marked this conversation as resolved.
devin-ai-integration[bot] marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| const syncButton = document.getElementById('connect-json-sync'); | ||
| const taskTableBody = document.getElementById('task-table-body'); | ||
|
|
||
| const LOADING_TITLE = '프로젝트 데이터를 불러오는 중입니다.'; | ||
| const UNSUPPORTED_TITLE = '이 브라우저는 wbs.json 직접 저장 연결을 지원하지 않습니다.'; | ||
|
|
||
| /** | ||
| * Keep direct wbs.json writes fail-closed until the planner has rendered its | ||
| * hydrated state. The table body always receives either task rows or the empty | ||
| * state row from renderAll(), so its first rendered child is the bootstrap | ||
| * completion signal for both populated and intentionally empty projects. | ||
| */ | ||
| function updateJsonSyncAvailability() { | ||
| const bootstrapRendered = taskTableBody.childElementCount > 0; | ||
| const pickerSupported = typeof window.showSaveFilePicker === 'function'; | ||
| const ready = bootstrapRendered && pickerSupported; | ||
|
|
||
| syncButton.disabled = !ready; | ||
| if (ready) { | ||
| syncButton.removeAttribute('aria-disabled'); | ||
| syncButton.title = ''; | ||
| return; | ||
| } | ||
|
|
||
| syncButton.setAttribute('aria-disabled', 'true'); | ||
| syncButton.title = bootstrapRendered ? UNSUPPORTED_TITLE : LOADING_TITLE; | ||
| } | ||
|
|
||
| updateJsonSyncAvailability(); | ||
|
|
||
| const bootstrapObserver = new MutationObserver(() => { | ||
| updateJsonSyncAvailability(); | ||
| if (taskTableBody.childElementCount > 0) { | ||
| bootstrapObserver.disconnect(); | ||
| } | ||
| }); | ||
|
|
||
| bootstrapObserver.observe(taskTableBody, { childList: true }); |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import assert from 'node:assert/strict'; | ||
| import test from 'node:test'; | ||
|
|
||
| process.env.SCOPEWEAVE_DB = ':memory:'; | ||
| process.env.SCOPEWEAVE_JWT_SECRET = '0123456789abcdef0123456789abcdef'; | ||
|
|
||
| const { app } = await import('../../server/app.mjs'); | ||
|
|
||
| test('cloud server serves the JSON sync bootstrap guard as JavaScript', async () => { | ||
| const response = await app.request('/json-sync-bootstrap-guard.js'); | ||
|
|
||
| assert.equal(response.status, 200); | ||
| assert.match(response.headers.get('content-type') || '', /^text\/javascript\b/); | ||
| assert.match(await response.text(), /updateJsonSyncAvailability/); | ||
| }); | ||
|
devin-ai-integration[bot] marked this conversation as resolved.
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.