-
Notifications
You must be signed in to change notification settings - Fork 0
π¨ Palette: λΉμνΈμμ© ν΄ν μμμ ν€λ³΄λ μ κ·Όμ± κ°μ #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -999,6 +999,8 @@ function createStatusCellContent(progressState) { | |
| if (progressState.description) { | ||
| badge.title = progressState.description; | ||
| badge.setAttribute('aria-label', `${progressState.label} - ${progressState.description}`); | ||
| badge.tabIndex = 0; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a project contains many dated tasks, every visible row receives one of the described progress states, so this adds one non-interactive keyboard stop per task. For example, a 100-row WBS now requires 100 additional Tab presses to reach controls after the table, even though screen readers can already encounter the labeled badge while navigating table content. Use visible descriptive text, a shared focusable help control, or a roving-focus pattern instead of placing every badge in the page-wide tab sequence. Useful? React with πΒ / π. |
||
| badge.setAttribute('role', 'note'); | ||
| } | ||
| return badge; | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,18 +29,18 @@ <h1>ScopeWeave Planner</h1> | |
| <span>κΈ°μ€μΌ</span> | ||
| <input data-testid="base-date-input" id="base-date" type="date" /> | ||
| </label> | ||
| <div class="meta-value-card" title="νλ‘μ νΈμ μμ κΈ°κ°(μΌμ) ν©κ³μ λλ€."> | ||
| <div class="meta-value-card" title="νλ‘μ νΈμ μμ κΈ°κ°(μΌμ) ν©κ³μ λλ€." tabindex="0" role="note"> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a sighted keyboard-only user tabs to these cards, the new focus outline appears but the explanatory text remains unavailable because native Useful? React with πΒ / π. |
||
| <span class="meta-label">μ 체μΌμ</span> | ||
| <strong data-testid="summary-total-days" id="summary-total-days">0μΌ</strong> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="meta-grid meta-grid-secondary"> | ||
| <div class="meta-value-card accent-card plan-card" title="κΈ°κ°(μΌμ) κ°μ€μΉκ° λ°μλ νλ‘μ νΈ μ 체 κ³ν μ§μ²λ₯ μ λλ€."> | ||
| <div class="meta-value-card accent-card plan-card" title="κΈ°κ°(μΌμ) κ°μ€μΉκ° λ°μλ νλ‘μ νΈ μ 체 κ³ν μ§μ²λ₯ μ λλ€." tabindex="0" role="note"> | ||
| <span class="meta-label">κ³νμ§μ²λ₯ (λμ )</span> | ||
| <strong data-testid="summary-planned-progress" id="summary-planned-progress">0.00%</strong> | ||
| </div> | ||
| <div class="meta-value-card accent-card actual-card" title="κΈ°κ°(μΌμ) κ°μ€μΉκ° λ°μλ νλ‘μ νΈ μ 체 μ€μ μ§μ²λ₯ μ λλ€."> | ||
| <div class="meta-value-card accent-card actual-card" title="κΈ°κ°(μΌμ) κ°μ€μΉκ° λ°μλ νλ‘μ νΈ μ 체 μ€μ μ§μ²λ₯ μ λλ€." tabindex="0" role="note"> | ||
| <span class="meta-label">μ€μ μ§μ²λ₯ (λμ )</span> | ||
| <strong data-testid="summary-actual-progress" id="summary-actual-progress">0.00%</strong> | ||
| </div> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -360,7 +360,9 @@ button { | |
| .secondary-button:focus-visible, | ||
| input:focus-visible, | ||
| select:focus-visible, | ||
| .gantt-bar:focus-visible { | ||
| .gantt-bar:focus-visible, | ||
| .meta-value-card:focus-visible, | ||
| .status-badge:focus-visible { | ||
|
Comment on lines
+364
to
+365
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
On the white and Useful? React with πΒ / π. |
||
| outline: 3px solid rgba(37, 99, 235, 0.5); | ||
| outline-offset: 2px; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π Info: Palette learnings entries dated 2024 not 2026
The placeholder literal
$(date +%Y-%m-%d)was replaced with2024-08-23, and the new entry also reads2024-08-23, while the PR date is 2026-08-23. Documentation-only, no runtime effect (palette.md, palette.md, palette.md).Was this helpful? React with π or π to provide feedback.