fix(opencode): cap 70B NIM output and lock released notes - #545
Conversation
Keep the published 1.0.0/1.0.1 changelog notes locked and align the optional 70B candidate with NVIDIA NIM's documented 1-4096 max_tokens range so OpenCode cannot request an over-limit completion. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
seonghobae
left a comment
There was a problem hiding this comment.
Reviewed the exact current head. The repository-local provider boundary is limited to NVIDIA NIM, the configured 49B/8B/70B identifiers and token limits align with NVIDIA's current NIM API references, GitHub Models/Copilot token bindings are removed, organization workflow ownership remains external, and focused regressions lock both the provider contract and released changelog notes. Approval is exact-head only; Draft state and all queued CI/security/organization gates must still complete before integration.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
@coderabbitai review |
|
|
Warning Review limit reached
Next review available in: 38 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
seonghobae
left a comment
There was a problem hiding this comment.
Reviewed the exact current head against protected develop and current NVIDIA primary API references. The bounded diff is ahead-only on develop, keeps organization review workflow ownership outside the repository, removes GitHub Models/Copilot credential bindings from the local OpenCode config, and matches NVIDIA's hosted limits for the configured 49B, 8B, and 70B candidates (including 49B max_tokens 65536 and 70B/8B max_tokens 4096). The focused regressions lock the provider contract and preserve published changelog notes. This approval is source-review evidence for exact head ef9f9a9 only; the current Strix annotation reports backend unavailability, so it remains non-passing security evidence and must be rerun authoritatively before merge.
|
@opencode-agent review Please review exact current head |
Keep the local OpenCode binding as NVIDIA_API_KEY and assert that AGENTS.md still documents the organization secret injection split. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head review of 2bdd2159664636a0d9c5c5b64c230ae2e6696716 against live develop@44e7903.
The NIM-only local OpenCode slice is unchanged and still correct: enabled_providers is nvidia-nim only, the client binding stays {env:NVIDIA_API_KEY}, the org secret remains NVIDIA_NIM_API_KEY, 70B output stays at 4096, and GitHub Models / Copilot tokens are absent. The new commit only locks that org-secret mapping in tests/unit/opencode-config.test.mjs.
Local verification on this head:
node tests/unit/opencode-config.test.mjsPASSnode tests/unit/changelog-release-notes.test.mjsPASS
Last pusher on this head is Cursor Agent, not the reviewer, so this approval can satisfy require_last_push_approval.
Analyze (python) failed during CodeQL init with GitHub HTTP 503, not a source finding. Retrigger exact-head default-setup checks after API and Actions recovered. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head review of c8eb58a86410c4f0d6e3be575a13d82d77826dba against live develop@44e7903.
This commit is empty and only retriggers required CodeQL after Analyze (python) failed in CodeQL init with GitHub HTTP 503 during the 2026-08-17 GitHub.com outage. The NIM-only local OpenCode slice is unchanged from 2bdd215:
enabled_providersisnvidia-nimonly- client binding stays
{env:NVIDIA_API_KEY} - org secret remains
NVIDIA_NIM_API_KEY - 70B output stays at 4096
- GitHub Models / Copilot tokens are absent
Last pusher on this head is Cursor Agent, not the reviewer, so this approval can satisfy require_last_push_approval. Predecessor 2bdd215 required org workflows (Strix, OpenCode, Noema, Semgrep, Security Scan) were green; this approval does not transfer those checks. Merge still requires exact-head Analyze (python) and the other required gates on c8eb58a.
Reconcile the hierarchy-domain root onto current protected develop, preserving #545 NVIDIA NIM/OpenCode configuration and released-note regressions while retaining the work-item hierarchy unit/coverage registrations.
Summary
Land the NVIDIA NIM-only local OpenCode development config on current
develop, then apply the two remaining current-head findings from #543.#543
def2dfbalready restores the published 1.0.0 / 1.0.1 changelog notes and switchesopencode.jsoncto NVIDIA NIM with{env:NVIDIA_API_KEY}. This successor keeps that slice and adds:meta/llama-3.3-70b-instructlimit.outputset to4096, matching NVIDIA NIMmax_tokens1–4096 (NIM 70B infer reference)tests/unit/changelog-release-notes.test.mjsso a later commit cannot delete published 1.0.0 / 1.0.1 notes againThe default 49B path stays at documented
max_tokens1–65536. Organization OpenCode / Strix / merge-scheduler workflows stay inContextualWisdomLab/.github. Local binding remains{env:NVIDIA_API_KEY}; org CI continues to mapNVIDIA_NIM_API_KEYinto that process binding. Do not restoregithub-models,STRIX_GITHUB_MODELS_TOKEN, orCOPILOT_GITHUB_TOKEN.Prefer this PR over #543 and over the unopened
c9cd78cbranch. After merge, continue the calendar grant stack (#541 / #539) and Clearfolio production adapter (#489) rather than opening another NIM-config PR.Test plan
node tests/unit/opencode-config.test.mjsnode tests/unit/changelog-release-notes.test.mjsnpm run test:uniton CI exact head