ci: map OpenCode NIM through NVIDIA_NIM_API_KEY - #542
Closed
cursor[bot] wants to merge 2 commits into
Closed
Conversation
Point local and CI OpenCode configs at nvidia-nim with NVIDIA_API_KEY, defaulting to llama-3.3-nemotron-super-49b-v1.5. Remove GitHub Models provider ids, STRIX_GITHUB_MODELS_TOKEN, and COPILOT_GITHUB_TOKEN from OpenCode review. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Keep the local OpenCode binding as NVIDIA_API_KEY, but inject the organization secret NVIDIA_NIM_API_KEY in CI. Lock the split in the Strix gate and AGENTS.md so the next edit cannot collapse the names. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Contributor
|
Superseded by #543 after fresh protected- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Landing vehicle for the NVIDIA NIM-only OpenCode cutover. Prefer this over #540.
Why this replaces #540
#540 correctly switches local and CI OpenCode config to
nvidia-nimand removes GitHub Models /COPILOT_GITHUB_TOKENfrom the OpenCode path. It still injectsNVIDIA_API_KEY: ${{ secrets.NVIDIA_API_KEY }}. The organization secret isNVIDIA_NIM_API_KEY. The OpenCode client binding stays{env:NVIDIA_API_KEY}.Without the mapping, OpenCode review steps receive an empty key and skip failed-check diagnosis.
Changes on top of #540
NVIDIA_API_KEY: ${{ secrets.NVIDIA_NIM_API_KEY }}.opencode.jsoncstill reads{env:NVIDIA_API_KEY}.scripts/ci/test_strix_quick_gate.shlocks the split and rejects a GitHub secret namedNVIDIA_API_KEY.AGENTS.mddocuments the local binding vs org secret so the next edit cannot collapse the names.STRIX_GITHUB_MODELS_TOKEN.Verification
bash scripts/ci/test_strix_quick_gate.shpassed.python3 -m pytest tests/config/test_strix_batch_size_source.py tests/config/test_strix_deleted_file_scope_source.py tests/config/test_strix_static_repo_adaptations.pypassed (6 tests).Do not merge #540. After this PR is check-clean, close #540 as superseded.