fix: prefer practical compatibility hours - #14
Conversation
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthrough호환성 추천의 기본 검색 범위를 09:00–23:00으로 제한하고, 선택 시 24시간 전체를 검색하도록 변경했습니다. 이 설정을 API, 캘린더 저장, 프론트엔드 표시, 문서와 테스트에 반영했으며 CI 커버리지 검사를 추가했습니다. Changes호환성 검색 범위
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Browser
participant preview_compatibility
participant generate_compatibility_candidates
participant create_compatibility_calendar
Browser->>preview_compatibility: include_overnight 전송
preview_compatibility->>generate_compatibility_candidates: 검색 범위 적용
generate_compatibility_candidates-->>preview_compatibility: 후보 반환
preview_compatibility-->>Browser: 결과와 검색 범위 반환
Browser->>create_compatibility_calendar: 선택 범위 전송
create_compatibility_calendar-->>Browser: 저장된 rule 반환
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head63d0f00acf8492d9e5d3bd6e0a6c30d6e4682070. -
Head SHA:
63d0f00acf8492d9e5d3bd6e0a6c30d6e4682070 -
Workflow run: 30437562009
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (6 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (6 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs (2 files)"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs (2 files)"]
R2 --> V2["docs review"]
Evidence --> S3["Test (2 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (2 files)"]
R3 --> V3["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (6 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (6 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs (2 files)"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs (2 files)"]
R2 --> V2["docs review"]
Evidence --> S3["Test (2 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (2 files)"]
R3 --> V3["targeted test run"]
|
Superseded automated review: its only blocker was central coverage tooling not recognizing requirements.lock. That reviewer defect was fixed and merged in ContextualWisdomLab/.github#644; the application head remains unchanged and must receive a fresh current-head model review.
|
정정합니다. 이 저장소의 통과 기준은 최신 헤드
리뷰에서 발견된 시간 기준 표기와 종료 시각 검증도 최신 헤드에서 수정했고, 모든 리뷰 스레드가 해결됐습니다. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
@coderabbitai review |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
pyproject.toml (1)
36-42: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win분기 커버리지도 함께 강제하는 것을 고려해 보세요.
현재 설정은 구문 커버리지만 100%를 요구합니다. 이 코드베이스는
include_overnight,time_mode등 조건 분기가 핵심 동작을 결정하므로branch = true가 회귀 방어에 더 효과적입니다.♻️ 제안 설정
[tool.coverage.run] source = ["app"] +branch = true🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pyproject.toml` around lines 36 - 42, Update the [tool.coverage.report] configuration in pyproject.toml to enable branch coverage with branch = true, while preserving the existing 100% fail_under requirement and missing-line reporting.tests/test_events.py (1)
106-115: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value테스트 의도를 값에 맞춰 정리하세요.
time_mode="invalid"여도 현재는_civil_from_calculation_time()가true_solar mode requires longitude를 먼저 내서 통과하지만, 이 케이스는 진태양시 경도 누락 검증으로 읽힙니다. 의도가 그거라면true_solar를 넘기고, 아니면 테스트를 별도 케이스로 분리하는 편이 좋습니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/test_events.py` around lines 106 - 115, Update the iter_chart_windows test case to pass "true_solar" as time_mode when asserting the "requires longitude" ValueError, so the test explicitly covers missing longitude validation. If invalid-mode validation is also required, add a separate focused test with its expected error.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/static/app.js`:
- Line 332: 추천 결과와 저장 캘린더 문구가 첫 번째 프로필의 time_mode를 반영하도록 업데이트하세요.
app/static/app.js 332-332의 `#pair-timezone` 및 app/static/app.js 255-255의 저장 캘린더
문구에 civil과 true_solar 기준을 구분해 표시하고, README.md 32-33, docs/ARCHITECTURE.md 39-41,
docs/research/README.md 85-86의 설명도 동일한 기준으로 갱신하세요.
In `@tests/test_api.py`:
- Around line 394-398: Update the event-time assertion around the
payload["events"] check so it validates the complete end time rather than the
always-true datetime.hour <= 23 condition. Ensure each event’s end date remains
the expected date and compare its time against the intended closing boundary,
adding the datetime.time import requested by the review.
---
Nitpick comments:
In `@pyproject.toml`:
- Around line 36-42: Update the [tool.coverage.report] configuration in
pyproject.toml to enable branch coverage with branch = true, while preserving
the existing 100% fail_under requirement and missing-line reporting.
In `@tests/test_events.py`:
- Around line 106-115: Update the iter_chart_windows test case to pass
"true_solar" as time_mode when asserting the "requires longitude" ValueError, so
the test explicitly covers missing longitude validation. If invalid-mode
validation is also required, add a separate focused test with its expected
error.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 3565f6cf-76da-400a-be66-25358a43a05c
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (17)
.github/workflows/ci.ymlREADME.mdapp/compatibility.pyapp/main.pyapp/static/app.jsapp/static/index.htmlapp/static/styles.cssdocs/ARCHITECTURE.mddocs/research/README.mdpyproject.tomltests/test_api.pytests/test_caldav.pytests/test_compatibility.pytests/test_events.pytests/test_rules.pytests/test_saju.pytests/test_store.py
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
github-project-automation
Bot
moved this from In Progress
to Done
in naruon Platform Roadmap
1 participant
Summary
Validation
uv run pytest -q— 66 passeduv run ruff check .node --check app/static/app.jsSummary by CodeRabbit
새로운 기능
문서
품질 개선