feat(instrument): reconcile bounded family-scoped catalog - #423
Draft
seonghobae wants to merge 12 commits into
Draft
seonghobae wants to merge 12 commits into
seonghobae wants to merge 12 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Historical Draft #304 contains the unique family-scoped durable catalog query, but its parent branch belonged to now-closed predecessor #303. That leaves #304 with stale ancestry and a misleadingly huge stacked diff. Current-main replacement #422 is the active parent for the bounded startable-instrument catalog, so this PR carries only the family-scoped delta on top of unchanged exact #422 head
98a575f2422c2eb0edba7d2fadc783158acf9ef5.TDD / reconciliation
b75c844ccc5baab4ceb73e68e4e589bb92dfb617and GREENab2f73dbf054dcb5e7189d7a9533a6ac380dcd77.44925fa41e9377f0d9a4c0073b29c727d397df53adds the family-scoped real-PostgreSQL contract before the API exists on feat(instrument): reconcile durable startable catalog onto current main #422.0813db3cf136aa16f8b2b58a3b81a6a4dbac2015adds the narrow database-side family query without changing the parent catalog's global paging contract.src/postgres_instrument_catalog.rsplustests/postgres_instrument_family_catalog.rs.Product contract
instrument_ref, including fail-closed rejection of trim aliases, numeric-like references, controls, and Unicode default-ignorable aliases.publishedpersisted releases, ordered deterministically by(locale, release_ref).PageRequiredrather than truncating or running unbounded when the family exceeds one page.Stack / supersession
This is a Draft child of #422. #422 must integrate first and this branch must then be reconciled to the integrated protected head before this PR can become merge-ready. It supersedes stale Draft #304 as the family-scoped landing vehicle; historical #304 checks/reviews do not transfer.
Acceptance
Do not merge until the unchanged exact final head is on the correct integrated parent, passes Runtime CI including the real PostgreSQL contract and exact owned statement/branch coverage, rustfmt/Clippy/rustdoc, Security/SAST, SPDX SBOM, supply-chain provenance, every live organization-required workflow, has zero valid unresolved findings, and satisfies qualifying independent non-author approval under the live ruleset. Pending, queued, skipped, cancelled, absent, stale, predecessor, synthetic, or model-only evidence is not passing. Never use administrator bypass or self-approval.