feat(result): render exact Korean and English personal reports - #259
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Changes다국어 결과 보고서
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: 🟡 Moderate · up to The PR changes participant-facing report language selection, but ko-KR still leaves metadata labels in English, so it can claim Korean while showing mixed-language content. This bounded localization correctness issue should be fixed or explicitly accepted before merge. Sequence Diagram(s)sequenceDiagram
participant Caller
participant LocalizedResultReport
participant ResultExport
participant ResultSnapshot
Caller->>LocalizedResultReport: from_snapshot(snapshot, input)
LocalizedResultReport->>ResultExport: 입력 검증 및 export 생성
ResultExport->>ResultSnapshot: 스냅샷 데이터 읽기
ResultExport-->>LocalizedResultReport: 검증된 메타데이터와 점수 반환
LocalizedResultReport-->>Caller: 로케일별 보고서 또는 오류 반환
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@opencode-agent review exact current head |
|
@opencode-agent Please review only the exact current head bfbf5f9 for localized result report against protected main 5544149. Do not transfer historical review or check evidence from an earlier head; the current required checks are running. Submit an independent formal review when current-head evidence is available. |
|
@opencode-agent Please review only exact head bfbf5f9 against protected main 5544149. Earlier REQUEST_CHANGES reviews cited superseded heads or coverage evidence from those heads; do not transfer them. Report only actionable findings against this current SHA, and approve only from current-head evidence. |
|
Reconciled exact head
This is validation evidence, not approval. |
|
@opencode-agent Please review only exact head |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Preserve the reviewed exact ko-KR/en-US participant report surface while incorporating protected main 4499d9c request-bound scoring-engine changes. The only overlapping path is src/lib.rs; this reconciliation retains localized_result_report and adds scoring_engine plus the exact protected-main source/tests without force-pushing or weakening gates.
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headf9894343ec00736071de4f2cae9e5e8ae0f2bedc. -
Head SHA:
f9894343ec00736071de4f2cae9e5e8ae0f2bedc -
Workflow run: 32700244834
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Docs: TRACEABILITY.md"]
S1 --> I1["operator or user guidance"]
I1 --> R1["Review risk: Docs: TRACEABILITY.md"]
R1 --> V1["docs review"]
Evidence --> S2["Changed file (2 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (2 files)"]
R2 --> V2["required checks"]
Evidence --> S3["Test: result_report_locale.rs"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test: result_report_locale.rs"]
R3 --> V3["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Docs: TRACEABILITY.md"]
S1 --> I1["operator or user guidance"]
I1 --> R1["Review risk: Docs: TRACEABILITY.md"]
R1 --> V1["docs review"]
Evidence --> S2["Changed file (2 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (2 files)"]
R2 --> V2["required checks"]
Evidence --> S3["Test: result_report_locale.rs"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test: result_report_locale.rs"]
R3 --> V3["targeted test run"]
|
1 participant
Why
Protected main can export immutable result scores to JSON and a human-readable report, but the report body is always English even when its declared locale is
ko-KR. That creates a participant-facing locale integrity gap: the artifact can claim one locale while rendering another language.What
ko-KRanden-US.ResultExportvalidation/copy boundary so scores, standard errors, participant identity, and scientific provenance are not recomputed.TDD lineage
b623c33d1b65c4690e00f2a062fe09e95a775a34imports the missing localized-report surface and requires Korean labels, English labels, preserved scores, and fail-closed locale resolution.4fdd0d91e7cc2b978f75c93def9263cfcf4adb11implements the exact-locale renderer.6759081a1d3220e3cda093cec2326b6524bfed90exports the runtime module.Boundary
This is presentation only. It does not change psychometric arithmetic, continuous/facet score authority, uncertainty, calibration, norms, DIF, instrument translation evidence, identity/consent authority, or cross-service ownership. Unsupported locales remain unavailable until reviewed participant-facing copy and the required scientific/translation evidence exist.
Merge discipline
Do not merge until the unchanged exact head passes live required CI/security/coverage/rustdoc/package/provenance gates, has zero valid unresolved findings, and has qualifying independent non-author review where required. Never self-approve.
Summary by CodeRabbit
새로운 기능
ko-KR)와 영어(en-US) 보고서를 지원합니다.오류 처리