feat(api): list startable published instruments over HTTP - #165
Draft
cursor[bot] wants to merge 22 commits into
Draft
cursor[bot] wants to merge 22 commits into
cursor[bot] wants to merge 22 commits into
Conversation
Expose GET /v1/instruments and GET /v1/instruments/{instrument_ref} so a purchaser can copy a published release_ref and locale into POST /v1/sessions. Hide draft, suspended, and retired rows. Keep the OpenAPI 3.2 contract limited to those two operations.
Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
This was referenced Aug 16, 2026
This was referenced Aug 16, 2026
…kens Production coverage missed parse_request_line's extra-token arm and the empty-buffer fail-closed return when a client closes before headers end.
Linux cargo fmt --check failed on the new unpublished-family test.
# Conflicts: # CHANGELOG.md # docs/TRACEABILITY.md # docs/adr/0014-api-and-event-contract-representation.md # docs/doctoring/standards-and-evidence.md # tests/documentation_architecture_contract.rs
# Conflicts: # CHANGELOG.md # docs/TRACEABILITY.md
seonghobae
marked this pull request as ready for review
August 27, 2026 09:17
seonghobae
marked this pull request as draft
August 27, 2026 09:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A purchaser cannot yet see which published locale-specific releases may start a new session. TRD §18 lists
GET /v1/instrumentsandGET /v1/instruments/{instrument_ref}as the first public catalog family. Session create (#149) needs arelease_refand exact locale; this slice makes those values discoverable without leaking draft, suspended, or retired work.Do not mix this onto #149 session HTTP, #150 research persistence, or #98 instrument load.
What
GET /v1/instrumentsreturns onlyPublishedreleases, ordered byinstrument_ref,locale, thenrelease_ref.GET /v1/instruments/{instrument_ref}returns that family's published releases, or 404 when the family has no startable row so unpublished catalog work stays hidden.openapi/instruments.yaml).release_refandlocaleintoPOST /v1/sessions.Boundary
This does not create sessions, persist the catalog, load PostgreSQL releases, expose item text, or implement other public families. #149 remains the session HTTP landing vehicle. #98 remains instrument persist/load.
Verification
cargo test --test instrument_http_contractcargo test --test documentation_architecture_contractcargo clippy --all-targets -- -D warningsResidual accepted on this slice
POST /v1/sessionsremains feat(api): create and reload in-process sessions over HTTP #149.