test(packaging): keep exact uv_build pin contract upgrade-safe - #167
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough패키징 메타데이터 테스트가 Changes패키징 메타데이터 검증
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository-owned CI defect exposed by #163
Dependabot PR #163 updates the exact
uv_buildpin from 0.12.1 to 0.12.3, buttests/test_packaging_metadata.pyhard-coded the old version. Exact-head CI therefore installs successfully and then fails one repository-owned assertion despite the source retaining an exactuv_build==X.Y.Zpin.This PR starts from protected main
d4c54f4cabea289b48ad6050e52d6a86d284828band changes only that contract test. It keeps the reproducibility requirement strict by requiring one exact semantic-version pin (uv_build==X.Y.Z) and explicitly rejecting range-baseduv_build>=...requirements, while leaving the actual version authority inpyproject.tomlwhere dependency update tooling can change it deliberately.No production code, dependency version, lockfile, provider behavior, schema, credential, workflow, release authority, or protected-branch policy changes. This is independent of the Dependabot branch and avoids racing its
pyproject.tomlownership.Merge only on an unchanged exact head after current CI/security/central required workflows are terminal-success and review threads are clear.
Summary by CodeRabbit
uv_build버전이 정확한X.Y.Z형식으로 고정되었는지 확인하며, 버전 범위 지정은 계속 거부합니다.