fix(durable): bound lifecycle failure evidence - #146
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough예약 및 스냅샷 영속성 실패를 제한된 오류 유형으로 변환합니다. Changes수명 주기 실패 증거
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related issues
Possibly related PRs
Sequence Diagram(s)sequenceDiagram
participant DurableBatchAPIClient
participant LifecycleCallback
participant GatewayError
DurableBatchAPIClient->>LifecycleCallback: 예약 또는 스냅샷 영속성 수행
LifecycleCallback-->>DurableBatchAPIClient: Exception 발생
DurableBatchAPIClient->>GatewayError: 제한된 오류 유형과 복구 컨텍스트 전달
GatewayError-->>DurableBatchAPIClient: 예외 체인 없는 오류 반환
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Test-first repair for #125. Durable lifecycle reservation/persistence currently exports dynamic exception class names and retains generic lower-layer exceptions in
GatewayErrorchains.RED boundary
Current head adds focused regressions for standalone and tenant-qualified clients. They require finite package-owned lifecycle failure categories, preservation of trusted recovery fields, and no retained dynamic class/message through
str,repr,response_data,__cause__, or__context__.This is intentionally RED until the protected-main defect is reproduced by exact-head CI. No predecessor checks or reviews transfer.
Scope
The eventual production fix is limited to the durable lifecycle recovery evidence boundary. It will not change provider transport, tenant/RLS persistence, schema, credentials, release authority, or recorder/reserver seams.
Refs #125.
Summary by CodeRabbit
새로운 기능
버그 수정
문서