Skip to content

🛡️ Sentinel: [MEDIUM] Fix information disclosure in error handling #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 5 commits into from
Closed

🛡️ Sentinel: [MEDIUM] Fix information disclosure in error handling #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
20679be
🛡️ Sentinel: Fix information disclosure in error handling
seonghobae Jul 8, 2026
c52ffc6
test: add real testthat coverage for vuongtest/icci core engine
Jul 8, 2026
9054e09
🛡️ Sentinel: Fix information disclosure in error handling
seonghobae Jul 8, 2026
e80a304
🛡️ Sentinel: Fix information disclosure in error handling
seonghobae Jul 9, 2026
91200c8
🛡️ Sentinel: Fix information disclosure in error handling
seonghobae Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
## 2024-05-31 - Silent Error Handling in R
**Vulnerability:** Information leakage through uncaught or default error handling in R `try()` statements.
**Learning:** In R, `try()` automatically prints error messages to standard error unless `silent = TRUE` is passed. This can leak internal execution errors, paths, or variables.
**Prevention:** Always use `try(expr, silent = TRUE)` or `tryCatch()` to gracefully handle exceptions and prevent information disclosure in error logs.
3 changes: 2 additions & 1 deletion R/llcont.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,8 @@ llcont.lavaan <- function(x, ...){
if(length(x.idx) == 1){
tmpll.x <- dnorm(X[,x.dat.idx], Mu.X, sqrt(Sigma.X), log=TRUE)
} else {
tmpll.x <- try(dmvnorm(X[,x.dat.idx], Mu.X, Sigma.X, log=TRUE))
# SECURITY: silent = TRUE prevents internal execution errors from leaking to standard error
tmpll.x <- try(dmvnorm(X[,x.dat.idx], Mu.X, Sigma.X, log=TRUE), silent=TRUE)
}
if(inherits(tmpll.x, "try-error")) tmpll.x <- NA
tmpll[case.idx] <- tmpll[case.idx] - tmpll.x
Expand Down
Loading