fix(release): bind immutable publication to protected main - #710
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough릴리스 검증에 보호된 Changes릴리스 보호 소스 게이트
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant ReleaseVerify
participant ProtectedSourceScript
participant GitRemote
ReleaseVerify->>ProtectedSourceScript: release:protected-source 실행
ProtectedSourceScript->>GitRemote: refs/heads/main 조회
GitRemote-->>ProtectedSourceScript: 보호된 main SHA 반환
ProtectedSourceScript-->>ReleaseVerify: PASS, SKIPPED 또는 오류 반환
Merge Risk: ⚪ Minimal · up to The release verification gate is wired into the release workflow and correctly compares the tagged commit with protected main. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head review for 8bc768756a10bab1d32b14039cdcfdb48d001931: test-first hosted RED is preserved; causal protected-main admission is bounded and fail-closed; base→head diff is limited to package wiring, the Noema-owned release source gate, and its regression tests; application CI, reviewer-ci, required Security Scan, patch-validator-image, Devin Review, and CodeRabbit are all GREEN; inline review threads are zero. No self-approval.
…ed-710-authority-20260913 docs(release): converge protected #710 authority
Problem
The release workflow verifies the tag, package version, release inventory, asset digests, attestations, and immutable publication, but it did not prove that the release commit is the exact protected
mainselected for release. AvMAJOR.MINOR.PATCHtag could therefore point at a non-protected commit that independently passesrelease:verifyand still enter immutable publication.RED
Test-only exact
4a937bafa1d688f39bfe95fd72d0424c1d90cf36added executable release-authority regressions before production code existed. Hosted application CI34758659968completed FAILURE at the release-tests step while typecheck and all preceding checkout/toolchain/base/lockfile controls passed, establishing the intended reality RED.Causal repair
scripts/release-protected-source.mjsadmits tag-triggered GitHub Actions release verification only when the release commit equals a freshly resolvedrefs/heads/mainfrom canonicalorigin.refs/heads/main.release:verifycontexts skip the live remote admission rather than introducing network dependence into ordinary verification.release:verifyandrelease:verify:strictinvoke this protected-source gate first.During exact diff review, the uppercase hostile fixture was found to use digit-only SHAs, so
.toUpperCase()was a no-op. Commit8bc768756a10bab1d32b14039cdcfdb48d001931repairs the fixture to contain hexadecimal letters; this changes only the regression's ability to exercise lowercase canonicalization, not the production contract.Exact-head GREEN
Final exact head:
8bc768756a10bab1d32b14039cdcfdb48d001931.34758877516: SUCCESS, including exact checkout/base controls, release typecheck/tests/security/KPI/license/acquisition verification, and final base-drift refusal.34758877486: SUCCESS, including 100% line+branch/docstring gates and real no-network CodeGraph sandbox path.34758877507: SUCCESS.34758877476: SUCCESS.No self-approval, gate weakening, force-push, destructive rebase, provider authority duplication, or release-policy substitution is part of this lane.