Skip to content

docs: converge protected #697 health media authority - #698

Merged
seonghobae merged 7 commits into
mainfrom
docs/orchestrator-health-media-authority-20260913
Sep 13, 2026
Merged

docs: converge protected #697 health media authority#698
seonghobae merged 7 commits into
mainfrom
docs/orchestrator-health-media-authority-20260913

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Documentation/contract finding

Protected #697 is now source authority for contextual-orchestrator /healthz media-type admission, but the code-current documentation and reusable consumer contract did not publish that authority. CHANGELOG.md and docs/product-technical-gap-baseline.md did not record #697, docs/orchestrator-gateway-consumer-contract.md described the JSON body but not the required response media type, and contracts/orchestrator-gateway.json / orchestratorGatewayConsumerContract() did not expose the new application/json health contract.

This lane converges protected source into Noema-owned documentation and consumer contract only. It does not promote protected source into immutable release/deployment/recovery/p95 evidence or transfer contextual-orchestrator service/provider/model routing, credential, outbound, quarantine/security, release/deployment, or foreign-domain authority into Noema.

Test-first RED

Test-only exact 773eb7cc523dc7a234976eee5caf5fc9ddb8f047 requires:

  • protected fix: require JSON media type for orchestrator health #697 exact source to be recorded in CHANGELOG and product-gap authority;
  • the reusable consumer contract and published JSON artifact to expose healthz.media_type = application/json;
  • the narrative consumer contract to require Content-Type: application/json;
  • unrelated protected history to remain byte-for-byte semantically present.

Hosted application CI 34727888635 reached exact checkout/toolchain/live-base/lockfile/install/typecheck and then failed in release tests, while Security Scan 34727888669, reviewer-ci 34727888711, and patch-validator-image 34727888612 succeeded on the test-only exact. This is the intended documentation-authority RED.

Causal repair

Current exact head 0b36053fd9ccea1662c0092706049447c2c5b1f4:

During diff review, the first contract-source edit also removed the pre-existing final newline from scripts/lib/orchestrator-gateway.mjs. That unrelated drift was repaired in ordinary follow-up commit 0b36053fd9ccea1662c0092706049447c2c5b1f4; the current base→head diff now contains only the intended contract/documentation convergence plus the test-first regression.

Summary by CodeRabbit

  • 변경 사항

    • /healthz 성공 응답에 Content-Type: application/json 요구사항이 추가되었습니다.
    • charset=utf-8 같은 매개변수는 허용되며, 미디어 타입이 없거나 JSON이 아니면 요청이 안전하게 거부됩니다.
    • 기존 상태 응답 본문 검증 규칙은 유지됩니다.
  • 문서

    • 관련 소비자 계약, 변경 로그 및 보호 기준 문서가 업데이트되었습니다.
  • 테스트

    • 계약 설정과 문서 내용이 일치하는지 검증하는 테스트가 추가되었습니다.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4c28cad1-7bf3-426d-a5d3-63410304a9d4

📥 Commits

Reviewing files that changed from the base of the PR and between 80b2343 and 0b36053.

📒 Files selected for processing (6)
  • CHANGELOG.md
  • contracts/orchestrator-gateway.json
  • docs/orchestrator-gateway-consumer-contract.md
  • docs/product-technical-gap-baseline.md
  • scripts/lib/orchestrator-gateway.mjs
  • test/orchestrator-health-media-authority.test.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

/healthz 계약에 application/json 미디어 타입 요구사항을 추가했습니다. 소스 계약, 게시 계약, 소비자 문서, 보호 기록을 갱신했습니다. 관련 문서와 계약의 일치를 검증하는 테스트를 추가했습니다.

Changes

Healthz 미디어 타입 계약

Layer / File(s) Summary
계약 및 기록 갱신
contracts/orchestrator-gateway.json, scripts/lib/orchestrator-gateway.mjs, docs/orchestrator-gateway-consumer-contract.md, docs/product-technical-gap-baseline.md, CHANGELOG.md
healthz 계약에 media_type: "application/json"을 추가했습니다. 소비자 문서와 보호 기록에 미디어 타입 검증 및 관련 진단을 기록했습니다.
계약 수렴 검증
test/orchestrator-health-media-authority.test.ts
게시된 계약과 소스 직렬화 결과의 일치를 검증합니다. PR 기록, 미디어 타입, 기존 보호 기록의 보존도 검증합니다.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: claude

Merge Risk: ⚪ Minimal · up to 0b360

The health-check media-type contract is consistently documented and validated across its published consumer surfaces.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (4 skipped: 4 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목은 보호된 #697의 healthz application/json 미디어 타입 계약을 문서와 게이트웨이 계약에 반영하는 주요 변경을 정확하고 간결하게 설명합니다.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/orchestrator-health-media-authority-20260913

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review September 13, 2026 00:43

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head review at 0b36053fd9ccea1662c0092706049447c2c5b1f4: test-only 773eb7cc523dc7a234976eee5caf5fc9ddb8f047 produced the intended documentation-authority RED; the current base→head diff is confined to protected #697 documentation/consumer-contract convergence plus the regression, with the incidental source final-newline drift repaired. Application CI 34728665518, reviewer-ci 34728665611, Security Scan 34728665569, and patch-validator-image 34728665572 are terminal SUCCESS. CodeRabbit reviewed exact base 80b23438b4443af95dc25b5a1f2782db3ef72233 through this head and generated no actionable comments; unresolved inline review threads are zero. COMMENT only; no self-approval.

@seonghobae
seonghobae merged commit 7e1016b into main Sep 13, 2026
18 checks passed
@seonghobae
seonghobae deleted the docs/orchestrator-health-media-authority-20260913 branch September 13, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant