Skip to content

docs(reviewer): remove stale local attempt controls - #640

Merged
seonghobae merged 3 commits into
mainfrom
docs/reviewer-attempt-authority-20260912
Sep 11, 2026
Merged

docs(reviewer): remove stale local attempt controls#640
seonghobae merged 3 commits into
mainfrom
docs/reviewer-attempt-authority-20260912

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Finding

Protected reviewer runtime already fails closed when NOEMA_LLM_REQUEST_TIMEOUT_SECONDS or NOEMA_LLM_MAX_RETRIES is configured and constructs the contextual-orchestrator client with timeout=None and max_retries=0. reviewer/README.md nevertheless advertised a 5,400-second Noema-local request timeout, bounded SDK retries, and both legacy environment variables as supported configuration. An operator following that documentation would configure values the runtime rejects and would reintroduce model-attempt allocation into Noema's documented authority.

RED

Test-only exact c23fd0045f7311615e0947299e43c7959ccdea6f added the executable documentation-authority regression. Hosted application CI run 34625616392 checked out that exact SHA, passed live-base/toolchain/install/typecheck, then failed at release tests: 675 existing test files / 4,690 existing tests passed and the new reviewer-readme-attempt-authority assertion alone failed on the stale timeout documentation.

Repair

Current exact 72ff4897822b5a8122540509346be4f3278a1379 removes the stale timeout/retry defaults and long-review retry claim, documents the already-protected runtime contract (timeout=None, max_retries=0), adds the actual NOEMA_LLM_ZDR_ONLY setting, and makes contextual-orchestrator the explicit model-attempt/retry/failover authority. The regression also rejects revival of the old 5,400-second / bounded-SDK-retry prose.

Scope

Documentation authority only. No provider/model/group routing, retry/failover implementation, credentials, quarantine/security/outbound authority, or product-domain truth moves into Noema. Keep Draft until this final exact head reaches all required hosted gates and receives a clean current-head review.

Summary by CodeRabbit

  • 문서

    • 리뷰 타임아웃 및 재시도 정책 문서를 업데이트했습니다.
    • 기존 타임아웃·재시도 설정은 레거시 항목으로 명시하고 반드시 해제하도록 안내합니다.
    • 새로운 NOEMA_LLM_ZDR_ONLY 설정을 추가했습니다.
    • 시도 할당, 재시도·페일오버 및 제공자 종료의 담당 주체를 명확히 했습니다.
    • 모델 대신 인퍼런스 정책 관련 용어를 사용하도록 설명을 정비했습니다.
  • 테스트

    • 문서가 새 설정 정책과 시도 제어 주체를 정확히 설명하는지 검증하는 테스트를 추가했습니다.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 3ec0a269-1e59-4053-9440-4a54e4cab979

📥 Commits

Reviewing files that changed from the base of the PR and between 6d61890 and 72ff489.

📒 Files selected for processing (2)
  • reviewer/README.md
  • test/reviewer-readme-attempt-authority.test.ts

📝 Walkthrough

Walkthrough

README가 Noema의 요청 제한과 SDK 재시도 설정을 갱신합니다. 시도 할당과 재시도 권한을 contextual-orchestrator에 귀속합니다. 새 NOEMA_LLM_ZDR_ONLY 설정과 문서 검증 테스트를 추가합니다.

Changes

시도 권한 문서

Layer / File(s) Summary
요청 정책과 권한 설명 갱신
reviewer/README.md, test/reviewer-readme-attempt-authority.test.ts
README가 timeout=Nonemax_retries=0을 명시합니다. 기존 timeout 및 retry 설정을 legacy로 표시하고 unset을 요구합니다. NOEMA_LLM_ZDR_ONLY를 추가합니다. 테스트가 해당 문구와 contextual-orchestrator 권한 설명을 검증합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/reviewer-attempt-authority-20260912

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-head review on 72ff4897822b5a8122540509346be4f3278a1379: the patch is scoped to reviewer operator-documentation authority plus its executable regression. It removes the two Noema-local attempt controls and the stale 5,400-second / SDK-retry claim, matches the protected runtime contract (timeout=None, max_retries=0, orchestrator/free), and does not move provider/model/retry/failover authority out of contextual-orchestrator. Hosted application CI, reviewer-ci, Security Scan, and patch-validator-image are all terminal success on this exact head; unresolved inline thread count is zero. No additional valid finding from this review.

@seonghobae
seonghobae marked this pull request as ready for review September 11, 2026 17:13
@seonghobae
seonghobae merged commit 2fae34f into main Sep 11, 2026
17 of 18 checks passed
@seonghobae
seonghobae deleted the docs/reviewer-attempt-authority-20260912 branch September 11, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant