docs(reviewer): remove stale local attempt controls - #640
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughREADME가 Noema의 요청 제한과 SDK 재시도 설정을 갱신합니다. 시도 할당과 재시도 권한을 Changes시도 권한 문서
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review on 72ff4897822b5a8122540509346be4f3278a1379: the patch is scoped to reviewer operator-documentation authority plus its executable regression. It removes the two Noema-local attempt controls and the stale 5,400-second / SDK-retry claim, matches the protected runtime contract (timeout=None, max_retries=0, orchestrator/free), and does not move provider/model/retry/failover authority out of contextual-orchestrator. Hosted application CI, reviewer-ci, Security Scan, and patch-validator-image are all terminal success on this exact head; unresolved inline thread count is zero. No additional valid finding from this review.
Finding
Protected reviewer runtime already fails closed when
NOEMA_LLM_REQUEST_TIMEOUT_SECONDSorNOEMA_LLM_MAX_RETRIESis configured and constructs the contextual-orchestrator client withtimeout=Noneandmax_retries=0.reviewer/README.mdnevertheless advertised a 5,400-second Noema-local request timeout, bounded SDK retries, and both legacy environment variables as supported configuration. An operator following that documentation would configure values the runtime rejects and would reintroduce model-attempt allocation into Noema's documented authority.RED
Test-only exact
c23fd0045f7311615e0947299e43c7959ccdea6fadded the executable documentation-authority regression. Hosted application CI run34625616392checked out that exact SHA, passed live-base/toolchain/install/typecheck, then failed atrelease tests: 675 existing test files / 4,690 existing tests passed and the newreviewer-readme-attempt-authorityassertion alone failed on the stale timeout documentation.Repair
Current exact
72ff4897822b5a8122540509346be4f3278a1379removes the stale timeout/retry defaults and long-review retry claim, documents the already-protected runtime contract (timeout=None,max_retries=0), adds the actualNOEMA_LLM_ZDR_ONLYsetting, and makes contextual-orchestrator the explicit model-attempt/retry/failover authority. The regression also rejects revival of the old 5,400-second / bounded-SDK-retry prose.Scope
Documentation authority only. No provider/model/group routing, retry/failover implementation, credentials, quarantine/security/outbound authority, or product-domain truth moves into Noema. Keep Draft until this final exact head reaches all required hosted gates and receives a clean current-head review.
Summary by CodeRabbit
문서
NOEMA_LLM_ZDR_ONLY설정을 추가했습니다.테스트