Skip to content

fix(naming): make runner-assignment evidence semantic - #533

Merged
seonghobae merged 72 commits into
mainfrom
fix/runner-assignment-semantic-evidence-names
Sep 6, 2026
Merged

fix(naming): make runner-assignment evidence semantic#533
seonghobae merged 72 commits into
mainfrom
fix/runner-assignment-semantic-evidence-names

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Scope

Translate GitHub-owned workflow-run/job REST fields at the read-only adapter boundary into Noema-owned semantic runner-assignment evidence while preserving current-attempt identity, bounded delegated GitHub capability use, stable schema-version-one operator output and acquisition package-byte rights evidence. Central runner capacity, provider routing, quarantine/security verdicts and outbound policy remain outside this PR.

Retained repair lineage

The branch retains the semantic audit_status / assignment-check evaluation internally while adapting it back to the established schema-v1 operator report at publication. Earlier review findings around stale nested report fields, missing changelog evidence and acquisition package-metadata integrity were repaired and all corresponding inline threads are resolved. The /ready finding was reverified as an invalid entrypoint assumption: wrangler.toml uses src/runtime-entrypoint.ts, whose GET/HEAD readiness contract is covered by tests.

After #546 and #544 reached protected truth, the branch was ordinarily/non-force converged onto main@71cd0fb6f3cf6ed1b886c8c312bfe96e7613f155. Current exact head is 8ced86c7636e3e5d09757459150df53e5329541e; compare is 72 ahead / 0 behind with merge-base exactly the protected head.

Exact-head release evidence — 2026-09-06 KST

On unchanged 8ced86c7636e3e5d09757459150df53e5329541e:

  • application CI 34006933314 — completed / success;
  • semantic reviewer 34006933327 — completed / success under the protected post-fix(reviewer): fail closed on empty CodeGraph semantics #546 reviewer contract;
  • required Security Scan 34006933311 — completed / success;
  • patch-validator-image 34006933451 — completed / success;
  • current inline review threads — zero unresolved.

No predecessor evidence is substituted. This PR is eligible for normal protected-main promotion at this exact head. Do not self-approve, force-push/destructively rebase, weaken gates or duplicate central/provider/security authority.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 12e72b19-ebf5-4829-80a0-227695e624b8

📥 Commits

Reviewing files that changed from the base of the PR and between f608670 and 162c0ab.

📒 Files selected for processing (1)
  • scripts/lib/actions-runner-assignment-source.mjs
🚧 Files skipped from review as they are similar to previous changes (1)
  • scripts/lib/actions-runner-assignment-source.mjs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

GitHub REST 실행·작업 필드를 의미론적 evidence 필드로 변환합니다. 평가기와 CLI 보고서 계약을 workflow_runs, workflow_jobs, audit_status, assignment_checks, assignment_failures로 갱신합니다. 라이선싱 검증 조건과 제품·권리 문서도 업데이트합니다.

Changes

러너 할당 evidence 명명 변경

Layer / File(s) Summary
소스 evidence 필드 변환
scripts/lib/actions-runner-assignment-source.mjs
GitHub 실행·작업 필드를 workflow_run_*workflow_job_* 필드로 변환하고 workflow_runsworkflow_jobs 구조로 반환합니다.
평가 계약 및 내부 필드 갱신
scripts/lib/actions-runner-assignment-audit.mjs
평가기 입력과 결과를 새 evidence 계약으로 변경합니다. 현재 run_attempt에 속한 작업을 평가합니다.
계약 및 평가 검증
test/actions-runner-assignment-*.test.ts
새 evidence 필드, 시도 무결성, 타임스탬프, 대기, 스톨 및 러너 할당 결과를 검증합니다.
CLI 보고서 계약 연결
scripts/actions-runner-assignment-audit.mjs, test/actions-runner-assignment-cli-semantic-report.test.ts
CLI가 semantic 결과를 schema-v1 보고서의 code, pass, detail 필드로 변환합니다.

라이선싱 및 권리 증거

Layer / File(s) Summary
패키지 라이선스 검증
scripts/acquisition-readiness-audit.mjs, test/acquisition-source-only-license.test.ts
배포 패키지에 package.json 라이선스와 보존된 bytes의 SHA-256 일치를 요구합니다. private 패키지는 해당 조건에서 제외합니다.
권리 증거 문서
LICENSE, docs/LICENSING_AND_IP_TRANSFER.md, docs/evidence-templates/transfer-evidence.example.json, docs/product-technical-gap-baseline.md, CHANGELOG.md
Apache-2.0 소스 권리, 패키지 metadata digest, 제3자 권리 및 현재 baseline을 갱신합니다.

제품 문서 및 저장소 안내

Layer / File(s) Summary
제품 표면 및 운영 안내
README.md, docs/index.md
제품 책임, HTTP 표면, 배포, smoke check, 보안 모델 및 evidence 경계를 설명합니다.
문서 검증
test/readme-customer-facing.test.ts
README의 제품 설명, 권한, 보안, 저장소 검증 및 라이선스 문구를 확인합니다.

Estimated code review effort: 4 (Complex) | ~45 minutes

Merge Risk: 🔵 Low · up to 162c0

The change leaves the repository documenting a GET/HEAD /ready endpoint that returns 404, so operators or integrations using the documented readiness check may receive an incorrect result. The PR is otherwise mergeable with explicit owner awareness and follow-up to align the documentation and runtime behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 17.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 35 functions across 17 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 runner-assignment evidence의 semantic naming 변경을 직접 설명합니다. 변경 범위와 일치하며 간결하고 명확합니다.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/runner-assignment-semantic-evidence-names

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

Base automatically changed from fix/codegraph-smoke-semantic-gate to main September 6, 2026 00:04
@seonghobae
seonghobae marked this pull request as ready for review September 6, 2026 04:33
@seonghobae
seonghobae merged commit 6f05e83 into main Sep 6, 2026
17 of 18 checks passed
@seonghobae
seonghobae deleted the fix/runner-assignment-semantic-evidence-names branch September 6, 2026 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: medium Normal-priority or P2 work status: needs-review type: bug Defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants