Skip to content

fix(ci): pin required GitHub-hosted runner selectors #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 6 commits into from
Sep 1, 2026
Merged

fix(ci): pin required GitHub-hosted runner selectors #532

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
92d3d02
test(ci): expose floating runner selector starvation
seonghobae Sep 1, 2026
7258397
fix(ci): pin reviewer runner image
seonghobae Sep 1, 2026
3c423df
fix(ci): pin verification runner image
seonghobae Sep 1, 2026
4d26101
fix(ci): pin image gate runner image
seonghobae Sep 1, 2026
fdea0a0
test(ci): reject quoted floating runner selectors
seonghobae Sep 1, 2026
9a3cbd2
docs(changelog): record pinned runner repair
seonghobae Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ concurrency:
jobs:
verify:
name: verify
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Resolved
timeout-minutes: 15
permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/patch-validator-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ env:
jobs:
verify_image:
name: verify-patch-validator-image
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 180
permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reviewer-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ permissions:
jobs:
reviewer:
name: reviewer
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 30
env:
NOEMA_CODEGRAPH_SANDBOX_SOURCE_IMAGE: gcr.io/distroless/java-base-debian13:nonroot
Expand Down
21 changes: 21 additions & 0 deletions test/workflow-runner-selector.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { readFileSync } from "node:fs";

import { describe, expect, it } from "vitest";

const requiredRunnerBackedWorkflows = [
".github/workflows/ci.yml",
".github/workflows/reviewer-ci.yml",
".github/workflows/patch-validator-image.yml",
] as const;

describe("required workflow runner selector", () => {
it.each(requiredRunnerBackedWorkflows)(
"%s uses the explicit supported Ubuntu runner image",
(workflowPath) => {
const workflow = readFileSync(workflowPath, "utf8");

expect(workflow).toContain("runs-on: ubuntu-24.04");
expect(workflow).not.toContain("runs-on: ubuntu-latest");
Comment thread
seonghobae marked this conversation as resolved.
Resolved
},
);
});
Loading