fix(oidc): roll forward trusted central workflow source - #494
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough감사된 중앙 워크플로 소스 커밋 SHA를 새 값으로 갱신했습니다. Wrangler 설정과 관련 테스트가 동일한 SHA를 사용하도록 변경했습니다. Changes워크플로 소스 SHA 갱신
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: 🟡 Moderate · up to This change updates the trusted central workflow source for OIDC security validation, but the exact commit still lacks a completed successful image validation check. Keep the PR unmerged until that required check reaches terminal success. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Roll Noema's immutable OIDC
job_workflow_shatrust anchor forward to the current protected central.githubsource commit without changing the reviewednoema-review.ymlworkflow bytes.Current evidence boundary
3d4ba0846352b2b10fd4506fa0aea29de32d079f.github/main:885f2cd251999f21cf562cab3e2d9cc3cc3ec737.github/workflows/noema-review.ymlblob:59b25e343444d0b97fc1c7ba33cb15543dd70102The central workflow blob is unchanged from the preceding trusted source revision, but GitHub OIDC
job_workflow_shabinds the source commit identity. Noema therefore must trust the current audited source commit rather than a predecessor commit with identical workflow bytes.Test-first lineage
5518c53ed5bfaafbd67c7f766db70aa40ae4a723: the executable trusted-workflow-source regression requires central source885f2cd...while production still trusts the predecessor source. This commit was immediately superseded; cancelled/queued workflow evidence on it is not treated as a terminal RED gate.b15cdd9554101a3038545c72d96a95ed75d32b44: changes only Noema-ownedwrangler.tomlto trust the same audited central source commit.d5be7af0f099a92f3d688b4bd2f567bd955590d0: non-destructively incorporates current protected Noema base after fix(pilot): reject placeholder or ambiguous readiness evidence #493 integrated. Current diff remains only the executable trust regression andALLOWED_WORKFLOW_SHAvalue.Current exact-head evidence
On unchanged exact head
d5be7af0f099a92f3d688b4bd2f567bd955590d0against base3d4ba084...:32632718435: success32632718478: success32632718705: successpatch-validator-image32632718448: in progress at exact-head image buildThe in-progress image run is non-passing. No predecessor image result substitutes for it.
Merge boundary
Keep Draft until the dedicated image workflow on the unchanged exact head reaches terminal-success, zero valid unresolved findings remain, and protected Noema base plus central source/workflow identity are freshly unchanged. Pending/in-progress/predecessor evidence is non-passing. This PR writes only Noema-owned trust configuration/tests; central
.githubremains read-only.Summary by CodeRabbit