-
Notifications
You must be signed in to change notification settings - Fork 0
fix(pilot): reject future completion dates #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
aa631bf
test(pilot): reject future completion evidence
seonghobae 0d9c387
fix(pilot): reject future completion evidence
seonghobae 8841e6f
docs(changelog): record pilot future-date rejection
seonghobae 20068ec
docs(changelog): preserve runner capability example
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
| import { evaluatePilotReadinessText } from "../scripts/lib/pilot-readiness.mjs"; | ||
|
|
||
| function completedPilotWithDates(handoverDate: string, onboardingDate: string) { | ||
| return `# 파일럿 온보딩 진행 기록 | ||
|
|
||
| ## 항목 1 | ||
| - 고객명: Acme Security | ||
| - NOEMA URL: https://noema.acme-security.com/exchange | ||
| - 지원 채널 합의: Slack acme-noema-ops | ||
| - 증빙 출처: production | ||
| - 계약/매출 증빙 경로: contracts/acme-paid-pilot.pdf | ||
| - 분석 데이터 경로: artifacts/saleable-readiness/noema-kpi-evidence.json | ||
| - exchange_failure_rate: 0 | ||
| - exchange_p95_latency_ms: 157 | ||
| - [x] 실패율 <= 0.02 | ||
| - [x] p95 < 300 | ||
| - [x] 운영 이관 승인 | ||
| - 운영 전환 승인일: ${handoverDate} | ||
| - 온보딩 완료일: ${onboardingDate} | ||
| - trace_id 샘플: trace-2f4c9a77-1e8a-4f3b-9b9a-a8c1e6f0b5d1 | ||
| `; | ||
| } | ||
|
|
||
| describe("pilot readiness completion chronology", () => { | ||
| it("rejects future completion dates instead of granting saleable-readiness authority", () => { | ||
| const result = evaluatePilotReadinessText(completedPilotWithDates("9999-12-30", "9999-12-31")); | ||
|
|
||
| expect(result.passed).toBe(false); | ||
| expect(result.entries[0].failures).toContain("운영 전환 승인일 must not be in the future"); | ||
| expect(result.entries[0].failures).toContain("온보딩 완료일 must not be in the future"); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.