fix(kpi): bind provenance log path identity - #490
Conversation
|
Warning Review limit reached
Next review available in: 46 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| if (provenanceLogPath !== null && provenanceLogPath !== expectedLogPath) { | ||
| return { | ||
| pass: false, | ||
| reason: "KPI provenance logPath must exactly identify the production log being verified when present.", | ||
| }; | ||
| } |
There was a problem hiding this comment.
📝 Info: logPath check skipped when field absent
The check at kpi-gate.mjs runs only when logPath is present, so provenance omitting it bypasses the binding. The bytes, digest, and record count of the verified log are still checked independently, so this is only advisory metadata. Non-string values fail closed.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
RED boundary
Strict KPI provenance verifies the bytes, digest, record count, source identity and reviewed source method for the production log passed to the gate, but currently retains
parsed.logPathwithout proving that it identifies those same bytes. A crafted provenance record can therefore claim a different production log path while the strict gate verifies another file.RED
a9039741c8633e2121f95f36040b5f37a82f2399adds a realistic 30-day production-log regression that supplies otherwise valid provenance with a differentlogPathand requires the strict gate to fail closed. Keep Draft until the RED is observed, the smallest production identity repair lands, and unchanged exact-head application/reviewer/Security evidence is terminal-success.