Skip to content

fix(acquisition): require canonical updated_at identity - #485

Merged
seonghobae merged 2 commits into
mainfrom
fix/acquisition-canonical-updated-at
Aug 23, 2026
Merged

fix(acquisition): require canonical updated_at identity#485
seonghobae merged 2 commits into
mainfrom
fix/acquisition-canonical-updated-at

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Purpose

Test-first acquisition evidence-integrity hardening. Buyer-facing updated_at metadata currently trims the supplied JSON string before ISO validation, so whitespace-padded timestamps can be normalized into freshness authority rather than rejected as non-canonical evidence.

RED

  • protected base: 2d8a07df19c5e9aa10887b8140d7768de237bea7
  • RED head: 38f45505d2b901c1a4c13f7a0c28d8638963d6f6
  • production source unchanged on this head
  • acceptance: " 2026-08-21T12:00:00Z " must fail with the existing updated_at must be an ISO date or timestamp evidence-integrity contract, while canonical date-only and timezone-bearing timestamps remain valid

Keep Draft until exact-head CI proves the RED and the smallest metadata-boundary repair receives fresh full GREEN evidence.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 10 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 81b01e3f-2084-4d33-b1b8-f4f4ad74e34f

📥 Commits

Reviewing files that changed from the base of the PR and between 2d8a07d and f274294.

📒 Files selected for processing (2)
  • scripts/acquisition-readiness-audit.mjs
  • test/acquisition-evidence-iso-date.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 23, 2026 01:59
@seonghobae
seonghobae merged commit 95a7ea2 into main Aug 23, 2026
16 of 17 checks passed
@seonghobae
seonghobae deleted the fix/acquisition-canonical-updated-at branch August 23, 2026 01:59

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant