fix(acquisition): require canonical evidence timestamps #439
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import { mkdtempSync, rmSync } from "node:fs"; | ||
| import { tmpdir } from "node:os"; | ||
| import { join } from "node:path"; | ||
| import { spawnSync } from "node:child_process"; | ||
| import { describe, expect, it } from "vitest"; | ||
|
|
||
| function runAudit(configuredMaxAgeDays: string) { | ||
| const outputDir = mkdtempSync(join(tmpdir(), "noema-acquisition-age-config-")); | ||
| const result = spawnSync(process.execPath, ["scripts/acquisition-readiness-audit.mjs"], { | ||
| cwd: process.cwd(), | ||
| encoding: "utf8", | ||
| env: { | ||
| ...process.env, | ||
| NOEMA_ACQUISITION_AUDIT_OUTPUT_DIR: outputDir, | ||
| NOEMA_ACQUISITION_EVIDENCE_MAX_AGE_DAYS: configuredMaxAgeDays, | ||
| }, | ||
| }); | ||
| rmSync(outputDir, { recursive: true, force: true }); | ||
| return result; | ||
| } | ||
|
|
||
| describe("acquisition evidence age configuration", () => { | ||
| for (const configuredMaxAgeDays of ["Infinity", "NaN", "0", "-1"]) { | ||
| it(`fails closed for explicit invalid max-age ${configuredMaxAgeDays}`, () => { | ||
| const result = runAudit(configuredMaxAgeDays); | ||
|
|
||
| expect(result.status).toBe(1); | ||
| expect(result.stderr).toContain( | ||
| "NOEMA_ACQUISITION_EVIDENCE_MAX_AGE_DAYS must be a positive finite number", | ||
| ); | ||
| }); | ||
| } | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,177 @@ | ||
| import { spawnSync } from "node:child_process"; | ||
| import { mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs"; | ||
| import { tmpdir } from "node:os"; | ||
| import { dirname, join, resolve } from "node:path"; | ||
| import { describe, expect, it } from "vitest"; | ||
|
|
||
| const auditScript = resolve("scripts/acquisition-readiness-audit.mjs"); | ||
|
|
||
| function writeFixture(root: string, relativePath: string, content: string): string { | ||
| const path = join(root, relativePath); | ||
| mkdirSync(dirname(path), { recursive: true }); | ||
| writeFileSync(path, content, "utf8"); | ||
| return path; | ||
| } | ||
|
|
||
| function prepareAuditRoot(prefix: string): string { | ||
| const root = mkdtempSync(join(tmpdir(), prefix)); | ||
| writeFixture( | ||
| root, | ||
| "docs/acquisition-readiness-2b.md", | ||
| "NOEMA-GOAL-ACQUISITION-2B-2026-07-02\nKRW 2,000,000,000\nRevenue_PASS\nTransfer_PASS\n", | ||
| ); | ||
| writeFixture( | ||
| root, | ||
| "docs/buyer-due-diligence-index.md", | ||
| "npm run acquisition:audit\nartifacts/acquisition/revenue-evidence.json\nartifacts/acquisition/transfer-evidence.json\n", | ||
| ); | ||
| writeFixture( | ||
| root, | ||
| "docs/library-boundary-decision.md", | ||
| "현재는 submodule을 만들지 않는다\nnpm workspaces\nSplit Triggers\n", | ||
| ); | ||
| writeFixture( | ||
| root, | ||
| "scripts/acquisition-data-room-manifest.mjs", | ||
| "// finalGatePassed data-room-manifest.json release-publication-receipt\n", | ||
| ); | ||
| writeFixture(root, "docs/saleable-program-goal-registry.md", "NOEMA-GOAL-SALEABLE-2026-07-02\n"); | ||
| writeFixture(root, "docs/pricing-draft.md", "pricing draft\n"); | ||
| writeFixture(root, "docs/terms-draft.md", "terms draft\n"); | ||
| writeFixture(root, "docs/sla-and-support.md", "support draft\n"); | ||
| return root; | ||
| } | ||
|
|
||
| function runAuditWithRevenueTimestamp(root: string, updatedAt: string, nowMs?: number) { | ||
| const revenuePath = writeFixture(root, "revenue.json", JSON.stringify({ | ||
| arr_krw: 300_000_000, | ||
| gross_margin: 0.75, | ||
| paid_customers: 3, | ||
| pipeline_weighted_krw: 0, | ||
| loi_count: 0, | ||
| customer_concentration_top1: 0.5, | ||
| updated_at: updatedAt, | ||
| owner: "finance", | ||
| source_documents: ["crm:noema-arr-report"], | ||
| })); | ||
| const outputDir = join(root, "audit-output"); | ||
| const inheritedEnvironment = Object.fromEntries( | ||
| Object.entries(process.env).filter(([key]) => !key.startsWith("NOEMA_")), | ||
| ); | ||
| const nodeArgs = [auditScript]; | ||
| if (nowMs !== undefined) { | ||
| const preloadPath = writeFixture(root, "freeze-now.mjs", `Date.now = () => ${nowMs};\n`); | ||
| nodeArgs.unshift("--import", preloadPath); | ||
| } | ||
| const result = spawnSync(process.execPath, nodeArgs, { | ||
| cwd: root, | ||
| env: { | ||
| ...inheritedEnvironment, | ||
| NOEMA_AUDIT_REPORT_ONLY: "1", | ||
| NOEMA_ACQUISITION_AUDIT_OUTPUT_DIR: outputDir, | ||
| NOEMA_ACQUISITION_EVIDENCE_MAX_AGE_DAYS: "36500", | ||
| NOEMA_REVENUE_EVIDENCE_PATH: revenuePath, | ||
| NOEMA_TRANSFER_EVIDENCE_PATH: join(root, "missing-transfer.json"), | ||
| NOEMA_PILOT_LOG_PATH: join(root, "missing-pilot.md"), | ||
| NOEMA_SALEABLE_AUDIT_PATH: join(root, "missing-saleable.json"), | ||
| NOEMA_DATA_ROOM_MANIFEST_PATH: join(root, "missing-data-room.json"), | ||
| }, | ||
| encoding: "utf8", | ||
| }); | ||
| const audit = JSON.parse(readFileSync(join(outputDir, "acquisition-audit.json"), "utf8")); | ||
| return { result, audit }; | ||
| } | ||
|
|
||
| function revenueMetadataFailures(audit: { checks: Array<{ name: string; details: { metadataFailures: string[] } }> }) { | ||
| return audit.checks.find( | ||
| (check) => check.name === "revenue evidence supports 2B target", | ||
| )!.details.metadataFailures; | ||
| } | ||
|
|
||
| describe("acquisition evidence timestamp integrity", () => { | ||
| for (const updatedAt of [ | ||
| "08/21/2026", | ||
| "2026-02-30", | ||
| "2026-08-21 12:00:00", | ||
| "2026-08-21T12:00:00+99:99", | ||
| ]) { | ||
| it(`rejects non-canonical updated_at ${updatedAt}`, () => { | ||
| const root = prepareAuditRoot("noema-acq-iso-date-"); | ||
| try { | ||
| const { result, audit } = runAuditWithRevenueTimestamp(root, updatedAt); | ||
| expect(result.status, result.stderr || result.stdout).toBe(0); | ||
| expect(revenueMetadataFailures(audit)).toContain( | ||
| "updated_at must be an ISO date or timestamp", | ||
| ); | ||
| } finally { | ||
| rmSync(root, { recursive: true, force: true }); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| it("rejects future-dated evidence instead of granting a one-day freshness grace period", () => { | ||
| const root = prepareAuditRoot("noema-acq-future-evidence-"); | ||
| try { | ||
| const updatedAt = new Date(Date.now() + 60 * 60 * 1000).toISOString(); | ||
| const { result, audit } = runAuditWithRevenueTimestamp(root, updatedAt); | ||
| expect(result.status, result.stderr || result.stdout).toBe(0); | ||
| expect(revenueMetadataFailures(audit)).toContain("updated_at cannot be in the future"); | ||
| } finally { | ||
| rmSync(root, { recursive: true, force: true }); | ||
| } | ||
| }); | ||
|
|
||
| it("accepts a date-only civil date that is current in a valid UTC+ timezone", () => { | ||
| const root = prepareAuditRoot("noema-acq-valid-ahead-date-"); | ||
| try { | ||
| const nowMs = Date.parse("2026-08-21T16:00:00.000Z"); | ||
| const { result, audit } = runAuditWithRevenueTimestamp(root, "2026-08-22", nowMs); | ||
| expect(result.status, result.stderr || result.stdout).toBe(0); | ||
| expect(revenueMetadataFailures(audit)).not.toContain("updated_at cannot be in the future"); | ||
| } finally { | ||
| rmSync(root, { recursive: true, force: true }); | ||
| } | ||
| }); | ||
|
|
||
| it("rejects a date-only civil date beyond the maximum ISO UTC+14 offset", () => { | ||
| const root = prepareAuditRoot("noema-acq-invalid-ahead-date-"); | ||
| try { | ||
| const nowMs = Date.parse("2026-08-21T09:59:59.999Z"); | ||
| const { result, audit } = runAuditWithRevenueTimestamp(root, "2026-08-22", nowMs); | ||
| expect(result.status, result.stderr || result.stdout).toBe(0); | ||
| expect(revenueMetadataFailures(audit)).toContain("updated_at cannot be in the future"); | ||
| } finally { | ||
| rmSync(root, { recursive: true, force: true }); | ||
| } | ||
| }); | ||
|
|
||
| it("accepts a canonical ISO date", () => { | ||
| const root = prepareAuditRoot("noema-acq-valid-iso-date-"); | ||
| try { | ||
| const updatedAt = new Date(Date.now() - 24 * 60 * 60 * 1000) | ||
| .toISOString() | ||
| .slice(0, 10); | ||
| const { result, audit } = runAuditWithRevenueTimestamp(root, updatedAt); | ||
| expect(result.status, result.stderr || result.stdout).toBe(0); | ||
| expect(revenueMetadataFailures(audit)).not.toContain( | ||
| "updated_at must be an ISO date or timestamp", | ||
| ); | ||
| } finally { | ||
| rmSync(root, { recursive: true, force: true }); | ||
| } | ||
| }); | ||
|
|
||
| it("accepts a canonical timezone-bearing ISO timestamp", () => { | ||
| const root = prepareAuditRoot("noema-acq-valid-iso-timestamp-"); | ||
| try { | ||
| const updatedAt = new Date(Date.now() - 60_000).toISOString(); | ||
| const { result, audit } = runAuditWithRevenueTimestamp(root, updatedAt); | ||
| expect(result.status, result.stderr || result.stdout).toBe(0); | ||
| expect(revenueMetadataFailures(audit)).not.toContain( | ||
| "updated_at must be an ISO date or timestamp", | ||
| ); | ||
| } finally { | ||
| rmSync(root, { recursive: true, force: true }); | ||
| } | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Info: Timestamp regex defers minute/second bounds to Date.parse
isoDateOrTimestampRegexvalidates hours strictly but accepts any\d{2}for minutes, seconds, and offset. Out-of-range values like12:60:00and+99:99are rejected only because V8's strict ISODate.parsereturns NaN at acquisition-readiness-audit.mjs. Correct, but the rejection depends on Date.parse, not the regex.Was this helpful? React with 👍 or 👎 to provide feedback.