fix(oidc): roll trust to reviewed central workflow source - #429
Merged
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Roll Noema's exact workflow-source allowlist from central
.githubcommitf16280a0aa215563d29200c5d0bab75c48af614ato current protected central commiteb0ee5c68c9e807644a920c1a5fb4caa1cf2fe97so OIDC exchange does not reject the current trustednoema-reviewworkflow source as stale.Exact dependency review
The central source is read-only from this writer. Comparing
f16280a...toeb0ee5c...shows two commits touching Strix/Python-security/hourly-review/docs/requirements paths only; neither.github/workflows/noema-review.ymlnorscripts/ci/noema_review_gate.pychanged. The trustednoema-review.ymlblob is exactly59b25e343444d0b97fc1c7ba33cb15543dd70102at both commits.This PR changes only
wrangler.toml'sALLOWED_WORKFLOW_SHA; it does not weaken exact SHA matching or accept multiple workflow sources.Evidence boundary
Keep Draft until fresh exact-head application CI, reviewer-ci, and eligible central Security Scan are terminal-success and central protected main/source identity is revalidated immediately before integration. If central moves again, re-review the intervening delta rather than blindly chasing the ref.