docs: retire stale canonical owner claims - #418
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthrough보호된 main 기준으로 문서 상태, 소유권, 커버리지 불변조건을 갱신했습니다. Delegated GitHub credential의 capability file 정책과 Issue 111의 미해결 상태를 기록했습니다. 관련 문서 계약 테스트도 현재 기준에 맞게 수정했습니다. Changes문서 기준 및 계약 갱신
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
August 17, 2026 22:04
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GH_TOKENSecurity boundary
Protected main already writes the short-lived Maintainer App token to an owner-only capability file and passes only
NOEMA_MAINTAINER_TOKEN_PATHto credential-bearing scripts. The helper rejects symlinks, non-regular files, owner mismatch, modes other than0600, file-identity races, oversized/invalid token material, and constructs a minimal child environment. This PR makes canonical PRD/traceability/gap audit match that protected implementation without equating a plaintext capability file to a governed KV/credential registry.Issue #111 remains open because
AGENTS.mdstill requires real script secrets to originate from KV/credential registry. An authorized governance decision must choose a real registry, a narrowly scoped Actions credential exception, or another reviewed registry design; automation does not make that decision here.TDD / repair lineage
The documentation contract was committed before the documentation repair. Exact-head application CI at
76dd5f0250bcbe7394fe28127e264e78a7eae515exposed two stale predecessor assertions in existing documentation tests: one still required closed PR #71 as an active owner, and one required literal historicalPR #413/PR #415integration wording. Those tests were repaired to assert protected semantic truth rather than obsolete PR-number prose. A follow-up contract prevents capability-file hardening from silently closing issue #111.Current exact head:
55ae86b2bbaa2c44c893b8a3deb122ac67fd91e9. Only this head's own terminal CI/reviewer/Security evidence may qualify it.Ownership
Noema-only documentation/test lane. It does not mutate central
.github,naruon,contextual-orchestrator, or other dedicated-writer repositories.Summary by CodeRabbit
문서
테스트