Skip to content

fix(ci): bound transient GitHub retries in live-base verification #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 2 commits into from
Closed

fix(ci): bound transient GitHub retries in live-base verification #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21dcab5
test(ci): require bounded live-base retries on transient GitHub failures
seonghobae Aug 17, 2026
02bb597
fix(ci): retry transient live-base GitHub failures
seonghobae Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 50 additions & 16 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,31 @@ jobs:
exit 1
fi
repository_name="${GITHUB_REPOSITORY#*/}"
live_base_sha="$(
gh api graphql \
-f query='query($owner:String!,$name:String!,$qualifiedName:String!){repository(owner:$owner,name:$name){ref(qualifiedName:$qualifiedName){target{oid}}}}' \
-F owner="$GITHUB_REPOSITORY_OWNER" \
-F name="$repository_name" \
-F qualifiedName="refs/heads/${NOEMA_PR_BASE_REF}" \
--jq '.data.repository.ref.target.oid'
)"
resolve_live_base_sha() {
local output=""
for attempt in 1 2 3; do
if output="$(
gh api graphql \
-f query='query($owner:String!,$name:String!,$qualifiedName:String!){repository(owner:$owner,name:$name){ref(qualifiedName:$qualifiedName){target{oid}}}}' \
-F owner="$GITHUB_REPOSITORY_OWNER" \
-F name="$repository_name" \
-F qualifiedName="refs/heads/${NOEMA_PR_BASE_REF}" \
--jq '.data.repository.ref.target.oid' \
2>&1
)"; then
printf '%s\n' "$output"
return 0
fi
if printf '%s\n' "$output" | grep -Eq '\(HTTP (502|503|504)\)$' && [ "$attempt" -lt 3 ]; then
sleep "$attempt"
continue
fi
printf '::error::Live pull-request base resolution failed after attempt %s.\n' "$attempt" >&2
return 1
done
return 1
}
live_base_sha="$(resolve_live_base_sha)"
if [[ ! "$live_base_sha" =~ ^[0-9a-f]{40}$ ]]; then
printf '::error::Live pull-request base ref did not resolve to a full commit SHA.\n'
exit 1
Expand Down Expand Up @@ -135,14 +152,31 @@ jobs:
exit 1
fi
repository_name="${GITHUB_REPOSITORY#*/}"
live_base_sha="$(
gh api graphql \
-f query='query($owner:String!,$name:String!,$qualifiedName:String!){repository(owner:$owner,name:$name){ref(qualifiedName:$qualifiedName){target{oid}}}}' \
-F owner="$GITHUB_REPOSITORY_OWNER" \
-F name="$repository_name" \
-F qualifiedName="refs/heads/${NOEMA_PR_BASE_REF}" \
--jq '.data.repository.ref.target.oid'
)"
resolve_live_base_sha() {
local output=""
for attempt in 1 2 3; do
if output="$(
gh api graphql \
-f query='query($owner:String!,$name:String!,$qualifiedName:String!){repository(owner:$owner,name:$name){ref(qualifiedName:$qualifiedName){target{oid}}}}' \
-F owner="$GITHUB_REPOSITORY_OWNER" \
-F name="$repository_name" \
-F qualifiedName="refs/heads/${NOEMA_PR_BASE_REF}" \
--jq '.data.repository.ref.target.oid' \
2>&1
)"; then
printf '%s\n' "$output"
return 0
fi
if printf '%s\n' "$output" | grep -Eq '\(HTTP (502|503|504)\)$' && [ "$attempt" -lt 3 ]; then
sleep "$attempt"
continue
fi
printf '::error::Live pull-request base resolution failed after attempt %s.\n' "$attempt" >&2
return 1
done
return 1
}
live_base_sha="$(resolve_live_base_sha)"
if [[ ! "$live_base_sha" =~ ^[0-9a-f]{40}$ ]]; then
printf '::error::Live pull-request base ref did not resolve to a full commit SHA.\n'
exit 1
Expand Down
9 changes: 9 additions & 0 deletions test/workflow-readiness.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,15 @@ describe("deployment workflow readiness gates", () => {
expect(workflow).toContain("if: always()");
});

it("bounds live-base GitHub retries to transient availability failures", () => {
const workflow = readFileSync(".github/workflows/ci.yml", "utf8");

expect(workflow.match(/for attempt in 1 2 3; do/g)).toHaveLength(2);
expect(workflow.match(/grep -Eq '\\\(HTTP \(502\|503\|504\)\\\)\$'/g)).toHaveLength(2);
expect(workflow.match(/sleep "\$attempt"/g)).toHaveLength(2);
expect(workflow.match(/Live pull-request base resolution failed after attempt/g)).toHaveLength(2);
});

it("runs the mandatory reviewer gate on every pull request", () => {
const workflow = readFileSync(".github/workflows/reviewer-ci.yml", "utf8");

Expand Down
Loading