fix(security): redact fine-grained PATs from workflow registry diagnostics - #409
Merged
seonghobae merged 3 commits intoAug 17, 2026
Merged
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
August 17, 2026 15:43
seonghobae
deleted the
fix/workflow-registry-fine-grained-token-redaction
branch
August 17, 2026 15:43
seonghobae
added a commit
that referenced
this pull request
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Harden the Noema-owned workflow-registry audit so failed collection and live GitHub CLI diagnostics cannot disclose fine-grained GitHub personal access tokens.
RED regression
Commit
5519e76179b17e599f07c800b6bb0b3dc4c16a1eadds an executable regression throughcollectLiveWorkflowRegistryAudit(): a simulated registry failure contains agithub_pat_...token and the returned failure detail must redact it. Protectedmainredacted bearer/classicgh*tokens but not fine-grained PATs.The first pull-request CI run (
32042751541) was stopped earlier by the repository's live-base verification step beforerelease verify, so that run is infrastructure/control evidence rather than a semantic test result. The defect itself is directly established by the protected-main sanitizer source and the regression contract; no skipped test is counted as passing evidence.Repair
fb018c4231b1c6d3094ef72936e7f1e076a298baaddsgithub_pat_...redaction to the bounded registry collection failure sanitizer.6344c4d5f4480b98d40a553957554e7e4b7e6522applies the same redaction at the liveghsubprocess diagnostic boundary so raw fine-grained PATs are removed before an error is propagated.gh*, bounded-length, UTF-8 and fail-closed behavior is retained.Verification boundary
This PR remains Draft until exact-current-head application CI, reviewer-ci and central Security Scan complete successfully. Predecessor runs and skipped steps do not count.
Ownership
No foreign dedicated-writer repository source/docs/refs are modified. This PR changes only
ContextualWisdomLab/noema.Related: #226