Skip to content

fix(security): harden maintainer readiness token capability reads - #395

Merged
seonghobae merged 9 commits into
mainfrom
fix/maintainer-token-capability-reader
Aug 16, 2026
Merged

fix(security): harden maintainer readiness token capability reads#395
seonghobae merged 9 commits into
mainfrom
fix/maintainer-token-capability-reader

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Purpose

Make maintainer-app readiness consume the same descriptor-safe delegated GitHub token capability contract already used by current Noema operator paths. Protected main still had a duplicate plain readFileSync(..., "utf8") reader that could accept symlinked or group/world-readable capability files even though the shared reader rejects them.

Test-first evidence

The first commit added realistic filesystem regressions for group/world-readable files and a symlink. The current exact head afa9bb60070dd8390a4f3652882d6e192d8bf8f6 replaces that duplicate weak reader with scripts/lib/delegated-github-token.mjs while preserving the existing token-path, GitHub CLI, readiness and fail-closed semantics.

Current gate boundary

The source repair is implemented, but required exact-head CI/reviewer/Security Scan evidence remains non-passing until GitHub assigns runners and those workflows terminate successfully. Current queued evidence must not be promoted to GREEN or merge readiness.

Authority boundary

This PR does not choose the broader KV-vs-short-lived-Actions-token governance decision in #111. It does not change GitHub permissions, reviewer/maintainer identities, workflow authority, release/deployment authority, or any central repository.

Related: #111.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 47b54c52-2a43-43b3-815e-9395bc5b2cf9

📥 Commits

Reviewing files that changed from the base of the PR and between 3843c1c and b418386.

📒 Files selected for processing (7)
  • .github/workflows/hourly-commercial-readiness.yml
  • .github/workflows/maintainer-app-readiness.yml
  • scripts/maintainer-app-readiness.mjs
  • test/github-credential-capability-ingress.test.ts
  • test/hourly-commercial-readiness-toolchain-integrity.test.ts
  • test/maintainer-app-helper-coverage.test.ts
  • test/maintainer-app-token-capability.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit a634066 into main Aug 16, 2026
16 checks passed
@seonghobae
seonghobae deleted the fix/maintainer-token-capability-reader branch August 16, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant