fix(security): harden maintainer readiness token capability reads - #395
Conversation
|
Warning Review limit reached
Next review available in: 46 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
Make maintainer-app readiness consume the same descriptor-safe delegated GitHub token capability contract already used by current Noema operator paths. Protected
mainstill had a duplicate plainreadFileSync(..., "utf8")reader that could accept symlinked or group/world-readable capability files even though the shared reader rejects them.Test-first evidence
The first commit added realistic filesystem regressions for group/world-readable files and a symlink. The current exact head
afa9bb60070dd8390a4f3652882d6e192d8bf8f6replaces that duplicate weak reader withscripts/lib/delegated-github-token.mjswhile preserving the existing token-path, GitHub CLI, readiness and fail-closed semantics.Current gate boundary
The source repair is implemented, but required exact-head CI/reviewer/Security Scan evidence remains non-passing until GitHub assigns runners and those workflows terminate successfully. Current queued evidence must not be promoted to GREEN or merge readiness.
Authority boundary
This PR does not choose the broader KV-vs-short-lived-Actions-token governance decision in #111. It does not change GitHub permissions, reviewer/maintainer identities, workflow authority, release/deployment authority, or any central repository.
Related: #111.