fix(observability): restack ambiguous alert JSON integrity on current main - #319
Closed
seonghobae wants to merge 1 commit into
Closed
fix(observability): restack ambiguous alert JSON integrity on current main#319seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Rebuild only PR #313's operational-alert JSON-integrity hardening onto current protected
mainafter #305 advanced the base. No predecessor CI, review, scanner, coverage, model, release, deployment, KPI, production, or acquisition authority transfers.Exact construction
mainimmediately before publication:534bf1708a6277c443867e87092ac5f2c05ea490;bbec93552e1b68b943a4860c6cc47cd38ad108e3;8d553a640d5c13b61a235aa0e7bd6e74b35e4ea4;scripts/evaluate-observability-alerts.mjsandtest/observability-alert-input-integrity.test.ts.The protected-main movement since #313's prior base changes only the distributed rate-limiter source/tests, so this successor overlays #313's exact two head blobs without overwriting intervening protected bytes.
Observability integrity contract
JSON-looking operational-alert NDJSON records are rejected on escape-equivalent duplicate decoded keys before route/status/latency/error/window classification. Malformed UTF-8 remains fail-closed and non-JSON Wrangler diagnostic noise remains tolerated. This is evidence-validation hardening only; it does not prove production KPI data, deployment, alert delivery, or operational acceptance.
Evidence boundary
Keep Draft until this unchanged exact head receives fresh terminal-success application
ci,reviewer-ci, and protected-base-eligible centralSecurity Scan, exact 100% owned production statement/branch/function/line coverage using realistic tests, and zero valid unresolved findings. Pending, queued, skipped, absent, neutral, failed, cancelled, stale, predecessor, status-only, model-only, or rate-limited evidence is non-passing.Immediately before Ready or merge, independently re-resolve protected main, exact head/base/ancestry, reviews/threads, checks and checkout SHAs, live rulesets, central Security Scan revision/triggers/base filters/thresholds, releases, and writer state.
Supersedes #313 only after fresh exact-head verification and protected integration.