fix(operations): restack workflow registry identity guards on current main - #316
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthrough워크플로 레지스트리 감사가 특정 저장소에만 적용되도록 검증을 추가했다. 수집 전 잘못된 저장소를 거부한다. 중복 레코드와 경로 재사용을 별도 실패 유형으로 분류한다. 관련 수집 및 분류 테스트를 추가·수정했다. Changes워크플로 레지스트리 검증
Estimated code review effort: 3 (Moderate) | ~20 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
August 14, 2026 18:28
This was referenced Aug 14, 2026
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Rebuild only PR #307's workflow-registry repository/duplicate/identity hardening onto the current protected-main lineage after #305 advanced
main. No predecessor CI, review, scanner, coverage, model, release, deployment, or operational authority transfers.Exact construction
mainimmediately before construction:534bf1708a6277c443867e87092ac5f2c05ea490;640e7d2bcb14136acd0df55b66a9eac85c382337;606fad5be3d36ad7d1b7ea85738d95f61942d782;scripts/workflow-registry-audit.mjs,test/workflow-registry-audit.test.ts,test/workflow-registry-collector-repository-binding.test.ts,test/workflow-registry-duplicate-records.test.ts, andtest/workflow-registry-repository-binding.test.ts.The only protected-main movement since #307's base changes the rate-limiter source/tests, so this successor overlays #307's exact five head blobs on the current protected-main tree without overwriting intervening protected bytes.
Security / reliability contract
The collector/classifier fails closed on wrong repository identity, repeated registry records, workflow-ID reuse across conflicting paths, and workflow-path reuse across conflicting IDs. It remains read-only evidence processing and cannot disable workflows or confer merge/release/deployment authority.
Evidence boundary
Keep Draft until this unchanged exact head receives fresh terminal-success application
ci,reviewer-ci, and protected-base-eligible centralSecurity Scan, exact 100% owned production statement/branch/function/line coverage with realistic tests, and zero valid unresolved findings. Pending, queued, skipped, absent, neutral, failed, cancelled, stale, predecessor, status-only, model-only, or rate-limited evidence is non-passing.Live Noema governance currently requires the central
.github/workflows/security-scan.yml@refs/heads/mainworkflow and does not currently impose an independent formal-approval rule. Immediately before Ready or merge, independently re-resolve protected main, exact head/base/ancestry, reviews/threads, checks and checkout SHAs, live rulesets, central scanner revision/triggers/base filters/thresholds, releases, and writer state.Supersedes #307 only after fresh exact-head verification and protected integration. Related: #226.
Summary by CodeRabbit
버그 수정
테스트