fix(security): restack validation-evidence JSON integrity on protected main - #304
Closed
seonghobae wants to merge 1 commit into
Closed
fix(security): restack validation-evidence JSON integrity on protected main#304seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Restack only #302's tested security-validation JSON-integrity delta onto current protected
mainafter #298 advanced the base. The predecessor branch remains untouched and no predecessor evidence transfers.Exact construction identity
mainbefore construction:10f7874f309cb120bc57b8c0cb637d1292650fe0(treec2ceeca94a8ecabec0f03dab11d56c7b99d54d1e);4c47ea7ed199e8d3397f6f5fdebd30d7cf0c09d2;9aae638b2b6754ae91549dca747f1364798e5304(treecc86d44339afeac33d47d9bef212903a2d3e6160);main;scripts/security-validation-evidence.mjs(+4/-0) and newtest/security-validation-evidence-duplicate-json.test.ts(+49/-0);78c524baddf230ccc622c444b2cc04a400141c2cand75780c6a2ca10b32f41395355472955b5534bd2b.Current protected-main source blob was independently refetched as
774cb32f870d5ee3cd5b35a30ad19798dbbf112d; the intervening #298 release-publication integration does not overlap this lane.Security behavior
After fatal UTF-8 decoding, run Noema's bounded decoded-key scanner before
JSON.parse, so contradictory literal/escape-equivalent members cannot collapse through JavaScript last-key-wins semantics before security-evidence evaluation. The focused regression requires fail-closedduplicate_keysforownerplus escape-equivalentow\u006eer. Existing checklist, malformed-JSON, evidence-evaluation, and audit-output semantics remain unchanged.Evidence boundary
Keep Draft until this unchanged exact head has fresh terminal-success application
ci,reviewer-ci, protected-base-eligible centralSecurity Scan, every other applicable live gate, exact 100% owned production statement/branch/function/line coverage with realistic tests, and zero valid unresolved findings. Pending, queued, skipped, absent, neutral, failed, cancelled, stale, predecessor, status-only, model-only, or rate-limited evidence is non-passing.Immediately before Ready or merge, independently refetch protected main, exact head/ref/ancestry, workflow checkout SHAs, reviews/threads/findings, live rulesets, central
.githubSecurity Scan authority, and active-writer state. Current observable ruleset requires the central Security Scan workflow and does not impose an independent approval rule; do not synthesize one.This change validates supplied evidence only. It does not create security-validation evidence, release/deploy, weaken gates, invent authority/evidence, create a repair writer, or choose an outbound license.