fix(security): restack inherited outbound body guard on current main - #297
Closed
seonghobae wants to merge 1 commit into
Closed
fix(security): restack inherited outbound body guard on current main#297seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Create a clean current-protected-main successor for #276. Its predecessor exact head had terminal-success application
ci,reviewer-ci, and centralSecurity Scan, but protectedmainhas since advanced by 24 commits relative to that lineage. Those predecessor results therefore do not authorize integration against the current live base.This successor preserves only the reviewed credential-egress request-body inheritance fix and its focused regressions.
Exact construction identity
mainimmediately before construction:e60eff4c71dc4997b9990a79daa5069d6f5e2037;a8658f034adfcc71c7e0af651f319dd651ed5603;4573a6f7eaf904e19a6e3198c8cabcfd4be40c40;02f348572987ce83aaf5a1cf9d408e316fd7571f;a60fa6d74f90e9f4f13220eb8c5a83c96ee16d5e;e60eff4c71dc4997b9990a79daa5069d6f5e2037;src/outbound-fetch-policy.ts, newtest/outbound-request-body-inheritance.test.ts, andtest/outbound-request-compartment.test.ts.Security defect and GREEN behavior
A body-bearing source
Requestcan be supplied together withRequestInit.body: nullor explicitundefined. Fetch semantics do not make those overrides a safe proof that the inherited source body disappeared. The credential-egress policy must evaluate the effective body-bearing request rather than authorize a bodyless shape that the actual request does not have.The successor keeps the reviewed correction:
RequestInit.bodyis treated as an explicit body;Request.body;body: nullcleared an inherited body is corrected;nulland explicitundefinedoverrides and requireblocked-request-policywith zero raw-fetch calls.#276 had zero formal reviews and zero inline review threads at the latest pre-write refetch.
Evidence boundary
No predecessor CI, coverage, scanner, review, model, release, or deployment evidence transfers. Keep Draft until this unchanged exact successor head has fresh terminal-success application
ci,reviewer-ci, protected-base-eligible centralSecurity Scan, exact 100% owned production statement/branch/function/line coverage with realistic tests, and zero valid unresolved findings.Immediately before Ready or merge, independently re-resolve protected main, exact head/ref/ancestry, workflow checkout SHAs, live rulesets, exact central
.githubSecurity Scan authority, reviews, threads, and active-writer state. Current live Noema policy requires the central Security Scan workflow and does not currently require a formal independent approval; no synthetic approval gate is imposed.No outbound allowlist expansion, request-shape relaxation, dependency change, repair/self-modifying workflow, policy waiver, release, deployment, invented evidence, or outbound-license decision is introduced.
Supersedes #276 only after fresh exact-head verification.