fix(governance): restack production protection ambiguity on current main - #295
Closed
seonghobae wants to merge 1 commit into
Closed
fix(governance): restack production protection ambiguity on current main#295seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Create a clean current-protected-main successor for #278 after its application CI correctly failed the live-base drift check. This successor preserves only the reviewed production-environment rule-ambiguity hardening and its focused regressions; predecessor checks and review evidence do not transfer.
Exact construction identity
mainimmediately before construction:e60eff4c71dc4997b9990a79daa5069d6f5e2037;af152e4fa1b698d563369712e3e8bb0e1e065797;4ef3af68879eae4f32259480843761b3a19fad7b;3b4bbb33b49a6aa15eb2f40b623ddd67093ee7ef;main, 1 ahead / 0 behind, merge base exactlye60eff4c71dc4997b9990a79daa5069d6f5e2037;scripts/lib/production-environment-governance.mjsandtest/production-environment-governance.test.ts.RCA and preserved behavior
#278's latest application run did not fail product logic. Exact-head checkout and package-manager verification succeeded, then
verify live pull-request base before lockfile controlfailed because protectedmainhad advanced. Its reviewer CI and central Security Scan were terminal success, but that predecessor evidence is historical only.The successor keeps the reviewed fail-closed behavior:
required_reviewersrules and require exactly one;branch_policyrules and require exactly one;required_reviewers_rule_ambiguousorbranch_policy_rule_ambiguousfor duplicate semantic authority;The earlier unused-variable finding on #278 is already addressed in the transplanted source; the predecessor inline thread is resolved/outdated.
Evidence boundary
This PR starts with no transferable CI, coverage, scanner, model, review, deployment, release, or production-environment evidence. Keep Draft until this unchanged exact head has fresh terminal-success application
ci,reviewer-ci, protected-base-eligible centralSecurity Scan, exact 100% owned production statement/branch/function/line coverage with realistic tests, and zero valid unresolved findings.Immediately before Ready or merge, re-resolve protected
main, exact head/ref/ancestry, workflow checkout SHAs, live rulesets, central.githubSecurity Scan authority, reviews, threads, and active-writer state. Current live Noema policy requires the central Security Scan workflow; it does not currently require an independent formal approval, so no synthetic approval requirement is imposed.This change does not assert that the live GitHub
productionenvironment passes, does not alter external reviewer/admin configuration, and does not publish, deploy, weaken gates, invent evidence, or choose an outbound license.Supersedes #278 after fresh exact-head verification.