fix(security): restack validation-evidence JSON integrity on current main - #294
Closed
seonghobae wants to merge 1 commit into
Closed
fix(security): restack validation-evidence JSON integrity on current main#294seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Create a clean protected-current successor for stale Draft #280 without force-pushing, rebasing, or mutating its predecessor branch. This Draft carries only the tested security-validation evidence JSON-integrity fix and its focused regression onto current protected
main.Exact construction identity
mainimmediately before creation:e60eff4c71dc4997b9990a79daa5069d6f5e2037b5aa1257cc4f06d92687310a7ffa048f6eb7b7afa8f0b6c78a8f067070bceee64362bd5e65ed4f63329bf9e7812c309ae3c0f929b918cf644cecd120scripts/security-validation-evidence.mjsandtest/security-validation-evidence-duplicate-json.test.ts774cb32f870d5ee3cd5b35a30ad19798dbbf112dis byte-identical to the predecessor's later protected-base production blob, so the transplant does not overwrite intervening protected-main changesTest-first behavior
The predecessor RED supplies contradictory
ownerand escape-equivalentow\u006eermember names. JavaScript's ordinary last-key-wins parsing can otherwise collapse those bytes beforeevaluateSecurityEvidence()makes a security-readiness decision.The GREEN reuses Noema's existing bounded decoded-key scanner and rejects duplicate decoded object keys before
JSON.parse. Fatal UTF-8 decoding, malformed-JSON classification, checklist evaluation, evidence evaluation, and audit output semantics remain unchanged.Evidence boundary
No predecessor CI, review, scanner, model, release, deployment, or acquisition evidence transfers. Keep Draft until this unchanged exact successor head has fresh terminal-success application
ci,reviewer-ci, protected-base-eligible centralSecurity Scan, exact 100% owned production statement/branch/function/line coverage with realistic tests, and zero valid unresolved findings.Pending, queued, skipped, absent, neutral, failed, cancelled, stale, predecessor, status-only, model-only, or rate-limited evidence is non-passing. Re-resolve protected main, exact head/ref/ancestry, workflow checkout SHAs, live rulesets, central Security Scan authority, reviews, and threads immediately before any Ready or merge action.
This Draft does not create security-validation evidence, publish a release, deploy production, choose an outbound license, or claim commercial/acquisition readiness.
Related: #280