fix(tests): develop is red — align governance tests with #926's central delegation - #935
Closed
seonghobae wants to merge 1 commit into
Closed
seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
develop is currently red: 9db32d0 (#926) removed the repo-local dependency-review workflow and the PR triggers on scorecard/trivy (the org central Security Scan owns the PR gate now) but did not update test_release_governance, so backend CI fails on every PR's merge ref. - stepsecurity test: dependency-review.yml removed from the hardened list; now asserts the duplicate file stays deleted (central supplies it). - code-scanning test: scorecard/trivy are push-only default-branch coverage; asserts pull_request triggers stay absent, locking #926's no-duplication intent instead of contradicting it. 29 passed locally (was 2 failed on origin/develop). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RkKdtHRLG4wSLh6PVsp8J
seonghobae
enabled auto-merge
July 6, 2026 23:48
Contributor
Author
|
Closing during org-wide PR backlog reduction. This looks like a low-priority automated maintenance PR ( |
auto-merge was automatically disabled
July 7, 2026 07:49
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (develop itself is red)
9db32d04(#926) removed the repo-localdependency-review.ymland thepull_requesttriggers on scorecard/trivy — correctly delegating PR scanning to the org central Security Scan — but didn't updatetests/test_release_governance.py. Result:backend (Python 3.14)fails on every PR's merge ref (verified by running the suite directly onorigin/develop: 2 failed). Combined with the trivy-fs gate issue, this is the second independent cause of the current org-wide PR stall; it went unnoticed because the runner freeze started right after #926 merged.Fix (aligns tests with #926's documented intent — no workflow changes)
test_stepsecurity_remediation_adds_pinned_audit_hardening: drop the deleteddependency-review.ymlfrom the hardened list; now asserts the duplicate file stays deleted (central supplies it).test_required_code_scanning_workflows_upload_scorecard_and_trivy_sarif: scorecard/trivy are push-only default-branch coverage; assertspull_request:triggers stay absent — locking the no-duplication intent instead of contradicting it.Verification
pytest tests/test_release_governance.py: 29 passed (was 2 failed onorigin/develop); ruff clean.Note
This unblocks the
backendcheck for every open PR once merged (it's on the merge ref).🤖 Generated with Claude Code