Skip to content

Block OpenCode approval on stale fact evidence - #664

Merged
seonghobae merged 1 commit into
developfrom
codex/opencode-fact-thread-gate
Jun 21, 2026
Merged

Block OpenCode approval on stale fact evidence#664
seonghobae merged 1 commit into
developfrom
codex/opencode-fact-thread-gate

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • add changed-docs current-head tree evidence to OpenCode review prompts so docs/asset absence claims are checked against repository facts
  • re-query unresolved non-outdated human review threads immediately before publishing an APPROVE review
  • request changes instead of approving when fresh human review feedback exists or reviewThreads cannot be read

Observed failure

PR #659 prepared OpenCode evidence before the human review thread at 2026-06-21T01:59:47Z, then approved at 2026-06-21T01:59:59Z. The new reviewThreads gate detects that unresolved human thread and blocks approval.

Validation

  • PR [codex] Record current DeepWiki gap task order #659 live GraphQL reviewThreads query returns the unresolved docs/ui-ux/README.md thread from @seonghobae
  • PR [codex] Record current DeepWiki gap task order #659 docs tree simulation shows docs/ui-ux/mockups/mockup_01.png and related assets on the PR head
  • bash -n scripts/ci/test_strix_quick_gate.sh
  • targeted assert_opencode_review_uses_codegraph_and_gpt5_fallback
  • git diff --check -- .github/workflows/opencode-review.yml scripts/ci/test_strix_quick_gate.sh
  • actionlint -shellcheck "" .github/workflows/opencode-review.yml

Note: default actionlint still reports the pre-existing SC2016 warnings in the existing Prepare bounded OpenCode review evidence GraphQL query; this branch does not add a new SC2016 warning.

@opencode-agent

opencode-agent Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: da5953203edd243b981aae416e2cb1d4f10b3db3
  • Workflow run: 27890978510
  • Workflow attempt: 1
  • Gate result: APPROVE (approval step)

Pull request overview

OpenCode reviewed the current-head bounded evidence and found no blocking issues.

Findings

No blocking findings.

Summary

The PR introduces changes to the OpenCode review workflow and adds functionality for detecting changed docs directories. No failed checks or structural issues were found.

  • Result: APPROVE
  • Reason: No blocking issues detected
  • Head SHA: da5953203edd243b981aae416e2cb1d4f10b3db3
  • Workflow run: 27890978510
  • Workflow attempt: 1

Risk Graph

flowchart LR
  Change[Changed surface] --> Risk[Main risk]
  Risk --> Fix[Smallest fix]
  Fix --> Verify[Verification]
Loading

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode reviewed the current-head bounded evidence and found no blocking issues.

Findings

No blocking findings.

Summary

The PR introduces changes to the OpenCode review workflow and adds functionality for detecting changed docs directories. No failed checks or structural issues were found.

  • Result: APPROVE
  • Reason: No blocking issues detected
  • Head SHA: da5953203edd243b981aae416e2cb1d4f10b3db3
  • Workflow run: 27890978510
  • Workflow attempt: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant