🎨 Palette: Checkbox Usability and Accessibility - #497
seonghobae wants to merge 2 commits into
Conversation
- Wrapped isolated checkboxes in `<label>` elements in `WorkspaceHome.tsx` and `CalendarLayout.tsx`. - Increased clickable area to include the task/calendar text. - Added `cursor-pointer`, hover styling (`group-hover:text-primary`), and `aria-label` definitions for improved mouse, keyboard, and screen-reader accessibility.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Wrapped isolated checkboxes in `<label>` elements in `WorkspaceHome.tsx` and `CalendarLayout.tsx`. - Increased clickable area to include the task/calendar text. - Added `cursor-pointer`, hover styling (`group-hover:text-primary`), and `aria-label` definitions for improved mouse, keyboard, and screen-reader accessibility.
Render
Destroyed
|
Superseded by #500. The actionable checkbox hit-target/accessibility changes from this PR were carried into #500 in commit 6f621d1 (frontend/src/components/CalendarLayout.tsx and frontend/src/components/WorkspaceHome.tsx). I did not carry over the .jules note. Local verification on #500 passed: pnpm --dir frontend test src/components/WorkspaceHome.dashboard.test.tsx src/app/calendar/page.test.tsx; git diff --check. This PR targeted master while the repository default branch is develop, which caused CodeRabbit to skip review on this PR. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
💡 What:
Wrapped isolated checkboxes in
<label>tags alongside their associated text inWorkspaceHome.tsxandCalendarLayout.tsx.🎯 Why:
Previously, users had to click precisely on the small checkbox square to toggle the status or view. Wrapping the checkbox and text in a label expands the clickable area to the entire row, making it much more intuitive and user-friendly, especially on touch devices or smaller screens.
♿ Accessibility:
cursor-pointerto indicate interactivity.focus-visiblestyling (focus-visible:ring-2) for better keyboard navigation.aria-labelattributes on the inputs to provide better context to screen readers.group-hoverstyles for clear visual feedback when interacting with the element.PR created automatically by Jules for task 14704570754046443683 started by @seonghobae