Skip to content

fix(strix): directly fallback on timeout instead of same-model retry - #285

Closed
seonghobae wants to merge 2 commits into
masterfrom
jules-4902158411740379790-775a3964
Closed

fix(strix): directly fallback on timeout instead of same-model retry#285
seonghobae wants to merge 2 commits into
masterfrom
jules-4902158411740379790-775a3964

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Bug 11 states: 'Timeout should move directly to fallback instead of retrying the same model.'

Previously, is_transient_same_model_retry_error checked if the model was NOT a vertex model and returned 0 (allowing retry). This commit removes that condition, so any timeout error immediately returns 1, thereby skipping the same-model retry logic and proceeding to fallback.


PR created automatically by Jules for task 4902158411740379790 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 12 minutes and 47 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a90f9616-bd3f-4b25-a18c-c8251ee070e2

📥 Commits

Reviewing files that changed from the base of the PR and between 29ea986 and 49b8415.

📒 Files selected for processing (2)
  • .github/workflows/strix.yml
  • scripts/ci/strix_quick_gate.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jules-4902158411740379790-775a3964

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

PR governance metadata gate is not ready for 49b8415f98542947a84be4545a14a5d36cdfcabc:

  • Branch is BEHIND the base branch; update the branch and re-run checks.
  • Current-head CodeRabbit issue comment has blocking warning/failure evidence on 49b8415.

@seonghobae
seonghobae temporarily deployed to jules-4902158411740379790-775a3964 - naruon PR #285 May 28, 2026 12:04 — with Render Destroyed
@seonghobae

Copy link
Copy Markdown
Contributor Author

Closing as superseded by #288. Master already prevents timeout from same-model retry, and this branch conflicts with the merged Vertex/org-secret Strix workflow while reintroducing stale OpenAI fallback wiring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant