fix(ci): exit early when all fallback models match primary - #284
fix(ci): exit early when all fallback models match primary#284seonghobae wants to merge 4 commits into
Conversation
The script was previously failing to exit after printing an ERROR when all fallback models matched the primary model. Added `return 1` to halt execution correctly.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
More reviews will be available in 43 minutes and 28 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR governance metadata gate is not ready for
|
…mary The script was previously failing to exit after printing an ERROR when all fallback models matched the primary model. Added `return 1` to halt execution correctly.
…mary The script was previously failing to exit after printing an ERROR when all fallback models matched the primary model. Added `return 1` to halt execution correctly.
…mary The script was previously failing to exit after printing an ERROR when all fallback models matched the primary model. Added `return 1` to halt execution correctly.
|
Closing as superseded by #288. Master already includes the fallback-exhaustion return path in scripts/ci/strix_quick_gate.sh, and this branch is now behind the Vertex/org-secret Strix workflow. |
The script was previously failing to exit after printing an ERROR when all fallback models matched the primary model (Bug 13). Adding
return 1fixes this logic so that the gate correctly halts execution and fails.PR created automatically by Jules for task 14209078825298172874 started by @seonghobae