Skip to content

fix(ci): exit early when all fallback models match primary - #284

Closed
seonghobae wants to merge 4 commits into
masterfrom
jules-14209078825298172874-b9258cf4
Closed

fix(ci): exit early when all fallback models match primary#284
seonghobae wants to merge 4 commits into
masterfrom
jules-14209078825298172874-b9258cf4

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

The script was previously failing to exit after printing an ERROR when all fallback models matched the primary model (Bug 13). Adding return 1 fixes this logic so that the gate correctly halts execution and fails.


PR created automatically by Jules for task 14209078825298172874 started by @seonghobae

The script was previously failing to exit after printing an ERROR
when all fallback models matched the primary model. Added `return 1`
to halt execution correctly.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 43 minutes and 28 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5492cf40-f153-4115-974f-ecc47387521a

📥 Commits

Reviewing files that changed from the base of the PR and between 29ea986 and 7036fc1.

📒 Files selected for processing (1)
  • scripts/ci/strix_quick_gate.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jules-14209078825298172874-b9258cf4

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

PR governance metadata gate is not ready for 7036fc1ebfe4dee612352b43df41027dfcb9b974:

  • Branch is BEHIND the base branch; update the branch and re-run checks.
  • Current-head CodeRabbit issue comment has blocking warning/failure evidence on 7036fc1.

…mary

The script was previously failing to exit after printing an ERROR
when all fallback models matched the primary model. Added `return 1`
to halt execution correctly.
…mary

The script was previously failing to exit after printing an ERROR
when all fallback models matched the primary model. Added `return 1`
to halt execution correctly.
…mary

The script was previously failing to exit after printing an ERROR
when all fallback models matched the primary model. Added `return 1`
to halt execution correctly.
@seonghobae

Copy link
Copy Markdown
Contributor Author

Closing as superseded by #288. Master already includes the fallback-exhaustion return path in scripts/ci/strix_quick_gate.sh, and this branch is now behind the Vertex/org-secret Strix workflow.

@seonghobae seonghobae closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant