-
Notifications
You must be signed in to change notification settings - Fork 1
Expose DAV source selection and conflict states #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| # DAV Source Selection and Conflict UI Phase | ||
|
|
||
| ## Goal | ||
|
|
||
| Close the next verified `docs/plans` and `frontend/branding` gap without | ||
| changing Naruon's source-of-truth boundary: Naruon remains a signed web | ||
| workspace/control plane over customer-owned CalDAV/CardDAV/WebDAV providers. | ||
|
|
||
| ## Verified Inputs | ||
|
|
||
| - `frontend/branding/naruon-ux-mockup-1.png` shows a dense operational home | ||
| workspace with navigable decisions, tasks, calendar, and mail surfaces rather | ||
| than static hero copy. | ||
| - `frontend/branding/naruon-ux-mockup-3.png` shows the Calendar workspace as a | ||
| month/week/detail/coordination/candidate surface with provider-backed | ||
| scheduling states. | ||
| - `docs/plans/2026-05-27-calendar-writeback-intent-ui.md` and | ||
| `docs/plans/2026-05-27-data-webdav-writeback-intent-ui.md` already require | ||
| signed source-registry reads, opaque target ids, ETag/If-Match visibility, and | ||
| no direct browser provider writes. | ||
| - Subagent audits confirmed that Calendar and Data already call signed intent | ||
| APIs, but Calendar auto-selected the first source and Data collapsed WebDAV | ||
| `409` conflicts into a generic error. | ||
|
|
||
| ## Implemented Slice | ||
|
|
||
| - Calendar source cards are selectable controls. The UI still initializes from | ||
| the first eligible source, but the selected opaque `source_id`, protocol, | ||
| capability list, ETag value, and writeback eligibility are visible before | ||
| `POST /api/calendar/writeback-intent`. | ||
| - Data WebDAV source cards are selectable controls. `POST | ||
| /api/webdav/writeback-intent` uses the selected opaque `source_id` and never | ||
| exposes sequential account ids in the browser request. | ||
| - WebDAV `409` responses render as If-Match/ETag conflicts so the UI does not | ||
| imply that Naruon overwrote a customer-owned file. | ||
| - The mobile hamburger drawer locks background body scroll while open and keeps | ||
| the drawer itself scrollable, matching the branding requirement for usable | ||
| mobile navigation across all primary destinations. | ||
| - README and AGENTS guardrails now record this bug pattern so future copied | ||
| Calendar/WebDAV examples do not revert to implicit source selection or generic | ||
| conflict errors. | ||
|
|
||
| ## Still Future Work | ||
|
|
||
| - Real connector/provider write execution remains out of scope until the | ||
| connector can enforce consent, capability, credential reference, remote href, | ||
| and ETag/If-Match checks server-side. | ||
| - `CaldavAccount` and `/dav` still need deeper registry consolidation so legacy | ||
| account ids and skeleton PUT behavior cannot be mistaken for a complete | ||
| provider write path. | ||
| - WebDAV project folder responses still need opaque folder ids in a backend | ||
| slice; this UI phase did not change that API contract. | ||
|
|
||
| ## Verification | ||
|
|
||
| ```bash | ||
| npm test -- src/app/calendar/page.test.tsx src/app/data/page.test.tsx | ||
| npm run typecheck | ||
| npm run build | ||
| npx playwright test tests/e2e/dashboard-branding.spec.ts --project=desktop -g "calendar writeback|data WebDAV" | ||
| npx playwright test tests/e2e/mobile-hamburger.spec.ts --project=desktop | ||
| ``` | ||
|
|
||
| Screenshots to inspect: | ||
|
|
||
| - `calendar-writeback-intent-desktop.png` | ||
| - `calendar-writeback-intent-mobile.png` | ||
| - `calendar-writeback-intent-mobile-scroll.png` | ||
| - `data-webdav-writeback-intent-desktop.png` | ||
| - `data-webdav-writeback-intent-mobile.png` | ||
| - `data-webdav-writeback-intent-mobile-scroll.png` | ||
| - `mobile-hamburger-open.png` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.