Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: correct Strix model to github_models/gpt-4o #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix: correct Strix model to github_models/gpt-4o #222
Changes from all commits
f9cf929ebb45e0d59d14f04a426464eba33c1ec3a12e3ed7d8b148e39f18e94911a69e7e44cf0File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: Seongho-Bae/naruon
Length of output: 1890
🏁 Script executed:
Repository: Seongho-Bae/naruon
Length of output: 3720
Narrow
SelfHostedConnector._listen_loopexception handling to avoid masking logic bugs.In
backend/runner/connector.pylines 54-59,_listen_loopcatches allException, logs a warning, and stops the loop—this suppresses failures fromhandle_messageand can hide programming errors.♻️ Proposed fix
async def _listen_loop(self): if not self.connection: return try: while self.is_connected: message = await self.connection.recv() await self.handle_message(message) - except Exception as e: - if websockets and isinstance(e, websockets.exceptions.ConnectionClosed): + except asyncio.CancelledError: + raise + except (OSError, asyncio.TimeoutError) as e: + logger.warning(f"Connection loop ended: {e}") + self.is_connected = False + except Exception as e: + if websockets and isinstance(e, websockets.exceptions.ConnectionClosed): logger.warning("Connection closed by remote gateway.") + self.is_connected = False else: - logger.warning(f"Connection loop ended: {e}") - self.is_connected = False + raise🧰 Tools
🪛 Ruff (0.15.13)
[warning] 54-54: Do not catch blind exception:
Exception(BLE001)
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.